ui/views/controls/webview/web_dialog_view.h - Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/webview/web_dialog_view.h

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/webview/web_dialog_view.h

diff --git a/ui/views/controls/webview/web_dialog_view.h b/ui/views/controls/webview/web_dialog_view.h

index 51d67eb88dc82460b85563f344799e92d4df8ef7..902aa3269be589509d7a140447437dacb66afff3 100644

--- a/ui/views/controls/webview/web_dialog_view.h

+++ b/ui/views/controls/webview/web_dialog_view.h

@@ -110,7 +110,8 @@ class WEBVIEW_EXPORT WebDialogView : public views::ClientView,

const gfx::Rect& initial_pos,

bool user_gesture,

bool* was_blocked) OVERRIDE;

- virtual void LoadingStateChanged(content::WebContents* source) OVERRIDE;

+ virtual void LoadingStateChanged(content::WebContents* source,

+ bool to_different_document) OVERRIDE;

virtual void BeforeUnloadFired(content::WebContents* tab,

bool proceed,

bool* proceed_to_fire_unload) OVERRIDE;