Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_impl.cc
diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc
index af32c0dc69ca4c6fb6f62a132be40d1b1ea2569c..aa8515664b3d8ad4633af073e3e7577c43ec4fa2 100644
--- a/content/browser/frame_host/interstitial_page_impl.cc
+++ b/content/browser/frame_host/interstitial_page_impl.cc
@@ -455,7 +455,7 @@ void InterstitialPageImpl::DidNavigate(
// an interstitial would hang.
web_contents_was_loading_ = controller_->delegate()->IsLoading();
controller_->delegate()->SetIsLoading(
- controller_->delegate()->GetRenderViewHost(), false, NULL);
+ controller_->delegate()->GetRenderViewHost(), false, true, NULL);
}
void InterstitialPageImpl::UpdateTitle(
@@ -600,7 +600,7 @@ void InterstitialPageImpl::Proceed() {
// Resumes the throbber, if applicable.
if (web_contents_was_loading_)
controller_->delegate()->SetIsLoading(
- controller_->delegate()->GetRenderViewHost(), true, NULL);
+ controller_->delegate()->GetRenderViewHost(), true, true, NULL);
// If this is a new navigation, the old page is going away, so we cancel any
// blocked requests for it. If it is not a new navigation, then it means the

Powered by Google App Engine
This is Rietveld 408576698