chrome/browser/ui/panels/panel_host.cc - Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_host.cc

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_host.cc

diff --git a/chrome/browser/ui/panels/panel_host.cc b/chrome/browser/ui/panels/panel_host.cc

index 59be3ae5cfe2a8a7d6a06b27b31175bc1df4be6c..b7ef95d22c6c4853e3204cb81361af7c9ff08543 100644

--- a/chrome/browser/ui/panels/panel_host.cc

+++ b/chrome/browser/ui/panels/panel_host.cc

@@ -160,8 +160,9 @@ void PanelHost::DeactivateContents(content::WebContents* contents) {

panel_->Deactivate();

}

-void PanelHost::LoadingStateChanged(content::WebContents* source) {

- bool is_loading = source->IsLoading();

+void PanelHost::LoadingStateChanged(content::WebContents* source,

+ bool to_different_document) {

+ bool is_loading = source->IsLoading() && to_different_document;

panel_->LoadingStateChanged(is_loading);

}