Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4485)

Unified Diff: chrome/browser/chromeos/login/simple_web_view_dialog.cc

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/simple_web_view_dialog.cc
diff --git a/chrome/browser/chromeos/login/simple_web_view_dialog.cc b/chrome/browser/chromeos/login/simple_web_view_dialog.cc
index 249a37f00fc2c296c997b42885d796caad932072..77b400094b02654913bbe83912f3ddcbb794af48 100644
--- a/chrome/browser/chromeos/login/simple_web_view_dialog.cc
+++ b/chrome/browser/chromeos/login/simple_web_view_dialog.cc
@@ -263,9 +263,10 @@ content::WebContents* SimpleWebViewDialog::OpenURL(
return NULL;
}
-void SimpleWebViewDialog::LoadingStateChanged(WebContents* source) {
+void SimpleWebViewDialog::LoadingStateChanged(WebContents* source,
+ bool to_different_document) {
bool is_loading = source->IsLoading();
- UpdateReload(is_loading, false);
+ UpdateReload(is_loading && to_different_document, false);
command_updater_->UpdateCommandEnabled(IDC_STOP, is_loading);
}

Powered by Google App Engine
This is Rietveld 408576698