Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/public/browser/web_contents_delegate.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 // This is called right after creation with the WebFrame for this RenderFrame. 94 // This is called right after creation with the WebFrame for this RenderFrame.
95 void SetWebFrame(blink::WebFrame* web_frame); 95 void SetWebFrame(blink::WebFrame* web_frame);
96 96
97 // Notification from RenderView. 97 // Notification from RenderView.
98 virtual void OnStop(); 98 virtual void OnStop();
99 99
100 // Start/Stop loading notifications. 100 // Start/Stop loading notifications.
101 // TODO(nasko): Those are page-level methods at this time and come from 101 // TODO(nasko): Those are page-level methods at this time and come from
102 // WebViewClient. We should move them to be WebFrameClient calls and put 102 // WebViewClient. We should move them to be WebFrameClient calls and put
103 // logic in the browser side to balance starts/stops. 103 // logic in the browser side to balance starts/stops.
104 // |to_different_document| will be true unless the load is a fragment
105 // navigation, or triggered by history.pushState/replaceState.
104 virtual void didStartLoading(bool to_different_document); 106 virtual void didStartLoading(bool to_different_document);
105 virtual void didStopLoading(); 107 virtual void didStopLoading();
106 virtual void didChangeLoadProgress(double load_progress); 108 virtual void didChangeLoadProgress(double load_progress);
107 109
108 #if defined(ENABLE_PLUGINS) 110 #if defined(ENABLE_PLUGINS)
109 // Notification that a PPAPI plugin has been created. 111 // Notification that a PPAPI plugin has been created.
110 void PepperPluginCreated(RendererPpapiHost* host); 112 void PepperPluginCreated(RendererPpapiHost* host);
111 113
112 // Notifies that |instance| has changed the cursor. 114 // Notifies that |instance| has changed the cursor.
113 // This will update the cursor appearance if it is currently over the plugin 115 // This will update the cursor appearance if it is currently over the plugin
(...skipping 365 matching lines...) Expand 10 before | Expand all | Expand 10 after
479 // Used to inform didChangeSelection() when it is called in the context 481 // Used to inform didChangeSelection() when it is called in the context
480 // of handling a InputMsg_SelectRange IPC. 482 // of handling a InputMsg_SelectRange IPC.
481 bool handling_select_range_; 483 bool handling_select_range_;
482 484
483 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 485 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
484 }; 486 };
485 487
486 } // namespace content 488 } // namespace content
487 489
488 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 490 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « content/public/browser/web_contents_delegate.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698