Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 // This is called right after creation with the WebFrame for this RenderFrame. 92 // This is called right after creation with the WebFrame for this RenderFrame.
93 void SetWebFrame(blink::WebFrame* web_frame); 93 void SetWebFrame(blink::WebFrame* web_frame);
94 94
95 // Notification from RenderView. 95 // Notification from RenderView.
96 virtual void OnStop(); 96 virtual void OnStop();
97 97
98 // Start/Stop loading notifications. 98 // Start/Stop loading notifications.
99 // TODO(nasko): Those are page-level methods at this time and come from 99 // TODO(nasko): Those are page-level methods at this time and come from
100 // WebViewClient. We should move them to be WebFrameClient calls and put 100 // WebViewClient. We should move them to be WebFrameClient calls and put
101 // logic in the browser side to balance starts/stops. 101 // logic in the browser side to balance starts/stops.
102 void didStartLoading(); 102 // |to_different_document| will be true unless the load is a fragment
103 // navigation, or triggered by history.pushState/replaceState.
104 void didStartLoading(bool to_different_document);
103 void didStopLoading(); 105 void didStopLoading();
104 106
105 #if defined(ENABLE_PLUGINS) 107 #if defined(ENABLE_PLUGINS)
106 // Notification that a PPAPI plugin has been created. 108 // Notification that a PPAPI plugin has been created.
107 void PepperPluginCreated(RendererPpapiHost* host); 109 void PepperPluginCreated(RendererPpapiHost* host);
108 110
109 // Notifies that |instance| has changed the cursor. 111 // Notifies that |instance| has changed the cursor.
110 // This will update the cursor appearance if it is currently over the plugin 112 // This will update the cursor appearance if it is currently over the plugin
111 // instance. 113 // instance.
112 void PepperDidChangeCursor(PepperPluginInstanceImpl* instance, 114 void PepperDidChangeCursor(PepperPluginInstanceImpl* instance,
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 // always respond properly to the request, so we don't have to worry so 429 // always respond properly to the request, so we don't have to worry so
428 // much about leaks. 430 // much about leaks.
429 IDMap<ContextMenuClient, IDMapExternalPointer> pending_context_menus_; 431 IDMap<ContextMenuClient, IDMapExternalPointer> pending_context_menus_;
430 432
431 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 433 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
432 }; 434 };
433 435
434 } // namespace content 436 } // namespace content
435 437
436 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 438 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698