Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 void set_swapped_out(bool is_swapped_out) { 113 void set_swapped_out(bool is_swapped_out) {
114 is_swapped_out_ = is_swapped_out; 114 is_swapped_out_ = is_swapped_out;
115 } 115 }
116 116
117 // Sets the RVH for |this| as pending shutdown. |on_swap_out| will be called 117 // Sets the RVH for |this| as pending shutdown. |on_swap_out| will be called
118 // when the SwapOutACK is received. 118 // when the SwapOutACK is received.
119 void SetPendingShutdown(const base::Closure& on_swap_out); 119 void SetPendingShutdown(const base::Closure& on_swap_out);
120 120
121 // TODO(nasko): This method is public so RenderViewHostImpl::Navigate can 121 // TODO(nasko): This method is public so RenderViewHostImpl::Navigate can
122 // call it directly. It should be made private once Navigate moves here. 122 // call it directly. It should be made private once Navigate moves here.
123 void OnDidStartLoading(); 123 // |to_different_document| will be true unless the load is a fragment
124 // navigation, or triggered by history.pushState/replaceState.
125 void OnDidStartLoading(bool to_different_document);
124 126
125 // Sends the given navigation message. Use this rather than sending it 127 // Sends the given navigation message. Use this rather than sending it
126 // yourself since this does the internal bookkeeping described below. This 128 // yourself since this does the internal bookkeeping described below. This
127 // function takes ownership of the provided message pointer. 129 // function takes ownership of the provided message pointer.
128 // 130 //
129 // If a cross-site request is in progress, we may be suspended while waiting 131 // If a cross-site request is in progress, we may be suspended while waiting
130 // for the onbeforeunload handler, so this function might buffer the message 132 // for the onbeforeunload handler, so this function might buffer the message
131 // rather than sending it. 133 // rather than sending it.
132 void Navigate(const FrameMsg_Navigate_Params& params); 134 void Navigate(const FrameMsg_Navigate_Params& params);
133 135
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 212
211 int routing_id_; 213 int routing_id_;
212 bool is_swapped_out_; 214 bool is_swapped_out_;
213 215
214 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 216 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
215 }; 217 };
216 218
217 } // namespace content 219 } // namespace content
218 220
219 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 221 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698