Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 virtual WebContents* OpenURL(const OpenURLParams& params) OVERRIDE; 297 virtual WebContents* OpenURL(const OpenURLParams& params) OVERRIDE;
298 298
299 // Implementation of IPC::Sender. 299 // Implementation of IPC::Sender.
300 virtual bool Send(IPC::Message* message) OVERRIDE; 300 virtual bool Send(IPC::Message* message) OVERRIDE;
301 301
302 // RenderFrameHostDelegate --------------------------------------------------- 302 // RenderFrameHostDelegate ---------------------------------------------------
303 virtual bool OnMessageReceived(RenderFrameHost* render_frame_host, 303 virtual bool OnMessageReceived(RenderFrameHost* render_frame_host,
304 const IPC::Message& message) OVERRIDE; 304 const IPC::Message& message) OVERRIDE;
305 virtual void RenderFrameCreated(RenderFrameHost* render_frame_host) OVERRIDE; 305 virtual void RenderFrameCreated(RenderFrameHost* render_frame_host) OVERRIDE;
306 virtual void RenderFrameDeleted(RenderFrameHost* render_frame_host) OVERRIDE; 306 virtual void RenderFrameDeleted(RenderFrameHost* render_frame_host) OVERRIDE;
307 virtual void DidStartLoading(RenderFrameHost* render_frame_host) OVERRIDE; 307 virtual void DidStartLoading(RenderFrameHost* render_frame_host,
308 bool to_different_document) OVERRIDE;
308 virtual void DidStopLoading(RenderFrameHost* render_frame_host) OVERRIDE; 309 virtual void DidStopLoading(RenderFrameHost* render_frame_host) OVERRIDE;
309 virtual void WorkerCrashed(RenderFrameHost* render_frame_host) OVERRIDE; 310 virtual void WorkerCrashed(RenderFrameHost* render_frame_host) OVERRIDE;
310 virtual void ShowContextMenu(RenderFrameHost* render_frame_host, 311 virtual void ShowContextMenu(RenderFrameHost* render_frame_host,
311 const ContextMenuParams& params) OVERRIDE; 312 const ContextMenuParams& params) OVERRIDE;
312 virtual WebContents* GetAsWebContents() OVERRIDE; 313 virtual WebContents* GetAsWebContents() OVERRIDE;
313 314
314 // RenderViewHostDelegate ---------------------------------------------------- 315 // RenderViewHostDelegate ----------------------------------------------------
315 virtual RenderViewHostDelegateView* GetDelegateView() OVERRIDE; 316 virtual RenderViewHostDelegateView* GetDelegateView() OVERRIDE;
316 virtual RenderViewHostDelegate::RendererManagement* 317 virtual RenderViewHostDelegate::RendererManagement*
317 GetRendererManagementDelegate() OVERRIDE; 318 GetRendererManagementDelegate() OVERRIDE;
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 InterstitialPageImpl* interstitial_page) OVERRIDE; 603 InterstitialPageImpl* interstitial_page) OVERRIDE;
603 604
604 // Unsets the currently showing interstitial. 605 // Unsets the currently showing interstitial.
605 virtual void DetachInterstitialPage() OVERRIDE; 606 virtual void DetachInterstitialPage() OVERRIDE;
606 607
607 // Changes the IsLoading state and notifies the delegate as needed. 608 // Changes the IsLoading state and notifies the delegate as needed.
608 // |details| is used to provide details on the load that just finished 609 // |details| is used to provide details on the load that just finished
609 // (but can be null if not applicable). 610 // (but can be null if not applicable).
610 virtual void SetIsLoading(RenderViewHost* render_view_host, 611 virtual void SetIsLoading(RenderViewHost* render_view_host,
611 bool is_loading, 612 bool is_loading,
613 bool to_different_document,
612 LoadNotificationDetails* details) OVERRIDE; 614 LoadNotificationDetails* details) OVERRIDE;
613 615
614 typedef base::Callback<void(WebContents*)> CreatedCallback; 616 typedef base::Callback<void(WebContents*)> CreatedCallback;
615 617
616 private: 618 private:
617 friend class NavigationControllerImpl; 619 friend class NavigationControllerImpl;
618 friend class TestNavigationObserver; 620 friend class TestNavigationObserver;
619 friend class WebContentsObserver; 621 friend class WebContentsObserver;
620 friend class WebContents; // To implement factory methods. 622 friend class WebContents; // To implement factory methods.
621 623
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
1058 // Whether this WebContents is responsible for displaying a subframe in a 1060 // Whether this WebContents is responsible for displaying a subframe in a
1059 // different process from its parent page. 1061 // different process from its parent page.
1060 bool is_subframe_; 1062 bool is_subframe_;
1061 1063
1062 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl); 1064 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
1063 }; 1065 };
1064 1066
1065 } // namespace content 1067 } // namespace content
1066 1068
1067 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1069 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698