Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 void set_swapped_out(bool is_swapped_out) { 84 void set_swapped_out(bool is_swapped_out) {
85 is_swapped_out_ = is_swapped_out; 85 is_swapped_out_ = is_swapped_out;
86 } 86 }
87 87
88 // Sets the RVH for |this| as pending shutdown. |on_swap_out| will be called 88 // Sets the RVH for |this| as pending shutdown. |on_swap_out| will be called
89 // when the SwapOutACK is received. 89 // when the SwapOutACK is received.
90 void SetPendingShutdown(const base::Closure& on_swap_out); 90 void SetPendingShutdown(const base::Closure& on_swap_out);
91 91
92 // TODO(nasko): This method is public so RenderViewHostImpl::Navigate can 92 // TODO(nasko): This method is public so RenderViewHostImpl::Navigate can
93 // call it directly. It should be made private once Navigate moves here. 93 // call it directly. It should be made private once Navigate moves here.
94 void OnDidStartLoading(); 94 void OnDidStartLoading(bool to_different_document);
95 95
96 protected: 96 protected:
97 friend class RenderFrameHostFactory; 97 friend class RenderFrameHostFactory;
98 98
99 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost 99 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost
100 // should be the abstraction needed here, but we need RenderViewHost to pass 100 // should be the abstraction needed here, but we need RenderViewHost to pass
101 // into WebContentsObserver::FrameDetached for now. 101 // into WebContentsObserver::FrameDetached for now.
102 RenderFrameHostImpl(RenderViewHostImpl* render_view_host, 102 RenderFrameHostImpl(RenderViewHostImpl* render_view_host,
103 RenderFrameHostDelegate* delegate, 103 RenderFrameHostDelegate* delegate,
104 FrameTree* frame_tree, 104 FrameTree* frame_tree,
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 169
170 int routing_id_; 170 int routing_id_;
171 bool is_swapped_out_; 171 bool is_swapped_out_;
172 172
173 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 173 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
174 }; 174 };
175 175
176 } // namespace content 176 } // namespace content
177 177
178 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 178 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698