X87: [for-in] Sanitize for-in optimizations and fix bailout points.

X87: [for-in] Sanitize for-in optimizations and fix bailout points.

  port f48bf12f5ea99a9d01d390c0c7f51dc85a87f1cd (r33426)

  original commit message:
  The PrepareId bailout location was used incorrectly in Crankshaft and,
  as it turns out, is not required anyway (once you do it right). Also
  there was some premature optimization going on with the CheckEnumCache
  (trying to load null from roots only once), plus we can be smarter about
  the null/undefined check anyway.

  The idea behind this changes is to prepare unification of the two
  different ForInPrepare implementations that we now have, with the end
  result being that we only use the new implementation that was recently
  added for the interpreter.

BUG=

Committed: https://crrev.com/512d8286c9c2f3888783c27c3c7fd50b687b1355
Cr-Commit-Position: refs/heads/master@{#33428}

[zhengxing.li, 2016-01-21 09:26:19]

zhengxing.li@intel.com changed reviewers:
+ bmeurer@chromium.org, chunyang.dai@intel.com, weiliang.lin@intel.com

[zhengxing.li, 2016-01-21 09:26:19]

PTAL, thanks!

[Weiliang, 2016-01-21 09:44:23]

lgtm

[zhengxing.li, 2016-01-21 09:56:23]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-01-21 09:56:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1611113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1611113002/1

[commit-bot: I haz the power, 2016-01-21 10:19:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-21 10:20:44]

Description was changed from

==========
X87: [for-in] Sanitize for-in optimizations and fix bailout points.

  port f48bf12f5ea99a9d01d390c0c7f51dc85a87f1cd (r33426)

  original commit message:
  The PrepareId bailout location was used incorrectly in Crankshaft and,
  as it turns out, is not required anyway (once you do it right). Also
  there was some premature optimization going on with the CheckEnumCache
  (trying to load null from roots only once), plus we can be smarter about
  the null/undefined check anyway.

  The idea behind this changes is to prepare unification of the two
  different ForInPrepare implementations that we now have, with the end
  result being that we only use the new implementation that was recently
  added for the interpreter.

BUG=
==========

to

==========
X87: [for-in] Sanitize for-in optimizations and fix bailout points.

  port f48bf12f5ea99a9d01d390c0c7f51dc85a87f1cd (r33426)

  original commit message:
  The PrepareId bailout location was used incorrectly in Crankshaft and,
  as it turns out, is not required anyway (once you do it right). Also
  there was some premature optimization going on with the CheckEnumCache
  (trying to load null from roots only once), plus we can be smarter about
  the null/undefined check anyway.

  The idea behind this changes is to prepare unification of the two
  different ForInPrepare implementations that we now have, with the end
  result being that we only use the new implementation that was recently
  added for the interpreter.

BUG=

Committed: https://crrev.com/512d8286c9c2f3888783c27c3c7fd50b687b1355
Cr-Commit-Position: refs/heads/master@{#33428}
==========

[commit-bot: I haz the power, 2016-01-21 10:20:45]

Patchset 1 (id:??) landed as
https://crrev.com/512d8286c9c2f3888783c27c3c7fd50b687b1355
Cr-Commit-Position: refs/heads/master@{#33428}