Document shutdown and suspend histograms for Chrome OS.

Document shutdown and suspend histograms for Chrome OS.

Add the following new histograms:

  Power.ShutdownReason
  Power.SuspendAttemptsBeforeCancel
  Power.SuspendAttemptsBeforeSuccess

Also deprecate Power.RetrySuspendCount, which was both
poorly-defined and broken.

BUG=337508
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251004

[Mark P, 2014-02-12 22:19:22]

lgtm

BTW, I'm happy to see that people are paying attention to metrics on Chrome OS. 
And even happier that you're improving metrics you find inaccurate / don't
trust.

--mark

P.S. Is Power.SuspendAttemptsBeforeCancel + Power.SuspendAttemptsBeforeSuccess =
all suspend attempts, or is there some other way of suspend attempts being
stopped?

[Daniel Erat, 2014-02-12 22:30:07]

On 2014/02/12 22:19:22, Mark P wrote:
> lgtm
> 
> BTW, I'm happy to see that people are paying attention to metrics on Chrome
OS. 
> And even happier that you're improving metrics you find inaccurate / don't
> trust.
> 
> --mark
> 
> P.S. Is Power.SuspendAttemptsBeforeCancel + Power.SuspendAttemptsBeforeSuccess
=
> all suspend attempts, or is there some other way of suspend attempts being
> stopped?

Thanks!

I expect the sum to roughly equal Power.SuspendAttempt but could imagine it
differing due to kernel crashes while suspending or due to the battery fully
discharging while the system is suspended. Power.SuspendAttempt gets reported
just before each suspend attempt, while the new histograms are reported after an
attempt has succeeded (and the system resumed) or a request has been canceled
between attempts. Should I go into this amount of detail in this file?

[Mark P, 2014-02-12 22:49:44]

On Wed, Feb 12, 2014 at 2:30 PM, <derat@chromium.org> wrote:

> On 2014/02/12 22:19:22, Mark P wrote:
>
>> lgtm
>>
>
>  BTW, I'm happy to see that people are paying attention to metrics on
>> Chrome
>>
> OS.
>
>> And even happier that you're improving metrics you find inaccurate / don't
>> trust.
>>
>
>  --mark
>>
>
>  P.S. Is Power.SuspendAttemptsBeforeCancel + Power.
>> SuspendAttemptsBeforeSuccess
>>
> =
>
>> all suspend attempts, or is there some other way of suspend attempts being
>> stopped?
>>
>
> Thanks!
>
> I expect the sum to roughly equal Power.SuspendAttempt but could imagine it
> differing due to kernel crashes while suspending or due to the battery
> fully
> discharging while the system is suspended. Power.SuspendAttempt gets
> reported
> just before each suspend attempt, while the new histograms are reported
> after an
> attempt has succeeded (and the system resumed) or a request has been
> canceled
> between attempts. Should I go into this amount of detail in this file?
>

Not necessary.

thanks,
mark


>
> https://codereview.chromium.org/161103002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Daniel Erat, 2014-02-12 22:59:16]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-02-12 23:02:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/161103002/40001

[commit-bot: I haz the power, 2014-02-13 01:25:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 01:25:55]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Daniel Erat, 2014-02-13 14:17:18]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-02-13 14:19:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/161103002/40001

[commit-bot: I haz the power, 2014-02-13 14:56:59]

Change committed as 251004