Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: server/logdog/storage/bigtable/bigtable_test.go

Issue 1610993002: LogDog: Add collector service implementation. (Closed) Base URL: https://github.com/luci/luci-go@master
Patch Set: Comments, rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « server/logdog/storage/bigtable/bigtable.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: server/logdog/storage/bigtable/bigtable_test.go
diff --git a/server/logdog/storage/bigtable/bigtable_test.go b/server/logdog/storage/bigtable/bigtable_test.go
index 88634e5fdcea4fb099d94efed7d041e90409438d..dbdb711004951bdb1c973a3f158c5b4592c85d96 100644
--- a/server/logdog/storage/bigtable/bigtable_test.go
+++ b/server/logdog/storage/bigtable/bigtable_test.go
@@ -5,10 +5,10 @@
package bigtable
import (
- "fmt"
"testing"
"github.com/luci/luci-go/common/errors"
+ "github.com/luci/luci-go/common/grpcutil"
. "github.com/smartystreets/goconvey/convey"
)
@@ -20,10 +20,12 @@ func TestBigTable(t *testing.T) {
})
Convey(`A regular error is not marked transient.`, t, func() {
- So(errors.IsTransient(wrapTransient(fmt.Errorf("boring error"))), ShouldBeFalse)
+ So(grpcutil.IsTransient(grpcutil.Canceled), ShouldBeFalse)
+ So(errors.IsTransient(wrapTransient(grpcutil.Canceled)), ShouldBeFalse)
})
- Convey(`An error containing "Internal error encountered" is marked transient.`, t, func() {
- So(errors.IsTransient(wrapTransient(fmt.Errorf("Hey, Internal error encountered!"))), ShouldBeTrue)
+ Convey(`An gRPC transient error is marked transient.`, t, func() {
+ So(grpcutil.IsTransient(grpcutil.Internal), ShouldBeTrue)
+ So(errors.IsTransient(wrapTransient(grpcutil.Internal)), ShouldBeTrue)
})
}
« no previous file with comments | « server/logdog/storage/bigtable/bigtable.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698