LogDog: Add collector service implementation.

server/logdog/storage/bigtable/bigtable.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package bigtable
 
 import (
         "fmt"
         "strings"
 
@@ skipping 34 matching lines @@
         //
         // rk is the starting row key.
         //
         // If the supplied limit is nonzero, no more than limit rows will be
         // retrieved.
         //
         // If keysOnly is true, then the callback will return nil row data.
         getLogData(c context.Context, rk *rowKey, limit int, keysOnly bool, cb btGetCallback) error
 }
 
+// btTransientSubstrings is the set of known error substrings returned by
+// BigTable that indicate failures that aren't related to the specific data
+// content.
+var btTransientSubstrings = []string{
+        "Internal error encountered",
+        "interactive login is required",

[dnj (Google), 2016/01/21 04:36:25]

Learning as we go.

+}
+
 // btTableProd is an implementation of the btTable interface that uses a real
 // production BigTable connection.
 type btTableProd struct {
         *bigtable.Table
 }
 
 func (t *btTableProd) putLogData(c context.Context, rk *rowKey, data []byte) error {
         m := bigtable.NewMutation()
         m.Set("log", "data", bigtable.ServerTime, data)
         cm := bigtable.NewCondMutation(bigtable.RowKeyFilter(rk.encode()), nil, m)
@@ skipping 78 matching lines @@
 // Since the BigTable API doesn't give us this information, we will identify
 // transient errors by parsing their error string :(
 //
 // TODO(dnj): File issue to add error qualifier functions to BigTable API.
 func isTransient(err error) bool {
         if err == nil {
                 return false
         }
 
         msg := err.Error()
-        if strings.Contains(msg, "Internal error encountered") {
-                return true
+        for _, s := range btTransientSubstrings {
+                if strings.Contains(msg, s) {
+                        return true
+                }
         }
         return false
 }
 
 // getLogData loads the "data" column from the "log" column family and returns
 // its []byte contents.
 //
 // If the row doesn't exist, storage.ErrDoesNotExist will be returned.
 func getLogData(row bigtable.Row) ([]byte, error) {
         ri := getReadItem(row, "log", "data")
@@ skipping 13 matching lines @@
 
         // Get the specific ReadItem for our column
         colName := fmt.Sprintf("%s:%s", family, column)
         for _, item := range items {
                 if item.Column == colName {
                         return &item
                 }
         }
         return nil
 }