Settings People Revamp: Implement Change People preview pane

chrome/test/data/webui/settings/change_picture_browsertest_chromeos.js

Index: chrome/test/data/webui/settings/change_picture_browsertest_chromeos.js
diff --git a/chrome/test/data/webui/settings/change_picture_browsertest_chromeos.js b/chrome/test/data/webui/settings/change_picture_browsertest_chromeos.js
index 52a977f6bbe2dfd76f504684d1bcb93df81389f1..fd0811b07980bcd52446641dd190bdf22c9b0bb1 100644
--- a/chrome/test/data/webui/settings/change_picture_browsertest_chromeos.js
+++ b/chrome/test/data/webui/settings/change_picture_browsertest_chromeos.js
@@ -75,6 +75,21 @@ TEST_F('SettingsChangePictureBrowserTest', 'MAYBE_ChangePicture', function() {
       changePicture.selectedImageUrl_ = '';
     });
 
+    test('select camera image', function() {
+      var cameraImage = changePicture.$$('#camera-image');
+      assertTrue(!!cameraImage);
+
+      expectFalse(changePicture.cameraActive);

[dpapad, 2016/01/21 18:11:40]

Why are we using expect() here instead of assert()? It seems that if
changePicture.cameraActive is true here, then the rest of this test should not
execute, which is achieved with assert().

[tommycli, 2016/01/21 18:47:05]

Done.

+      expectFalse(changePicture.$.previewImage.hidden);
+
+      MockInteractions.tap(cameraImage);
+
+      Polymer.dom.flush();
+
+      expectTrue(changePicture.cameraActive);
+      expectTrue(changePicture.$.previewImage.hidden);
+    });
+
     test('select profile image', function() {
       var profileImage = changePicture.$$('#profile-image');
       assertTrue(!!profileImage);
@@ -87,6 +102,7 @@ TEST_F('SettingsChangePictureBrowserTest', 'MAYBE_ChangePicture', function() {
 
         Polymer.dom.flush();
         expectTrue(profileImage.active);
+        expectFalse(changePicture.$.previewImage.hidden);
       });
     });
 
@@ -111,6 +127,7 @@ TEST_F('SettingsChangePictureBrowserTest', 'MAYBE_ChangePicture', function() {
         var oldImage = changePicture.$$('#old-image');
         assertTrue(!!oldImage);
         expectTrue(oldImage.active);
+        expectFalse(changePicture.$.previewImage.hidden);
       });
     });
 
@@ -128,6 +145,7 @@ TEST_F('SettingsChangePictureBrowserTest', 'MAYBE_ChangePicture', function() {
 
         Polymer.dom.flush();
         expectTrue(firstDefaultImage.active);
+        expectFalse(changePicture.$.previewImage.hidden);
       });
     });
   });