Settings People Revamp: Implement Change People preview pane

chrome/test/data/webui/settings/change_picture_browsertest_chromeos.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for settings-change-picture. */
 
 GEN_INCLUDE(['settings_page_browsertest.js']);
 
 /**
  * @constructor
@@ skipping 57 matching lines @@
       changePicture.addEventListener('selected-image-url_-changed', handler);
     });
   }
 
   suite('SettingsChangePicturePage', function() {
     setup(function() {
       // Reset the selected image to nothing.
       changePicture.selectedImageUrl_ = '';
     });
 
+    test('select camera image', function() {
+      var cameraImage = changePicture.$$('#camera-image');
+      assertTrue(!!cameraImage);
+
+      expectFalse(changePicture.cameraActive);

[dpapad, 2016/01/21 18:11:40]

Why are we using expect() here instead of assert()? It seems that if
changePicture.cameraActive is true here, then the rest of this test should not
execute, which is achieved with assert().

[tommycli, 2016/01/21 18:47:05]

Done.

+      expectFalse(changePicture.$.previewImage.hidden);
+
+      MockInteractions.tap(cameraImage);
+
+      Polymer.dom.flush();
+
+      expectTrue(changePicture.cameraActive);
+      expectTrue(changePicture.$.previewImage.hidden);
+    });
+
     test('select profile image', function() {
       var profileImage = changePicture.$$('#profile-image');
       assertTrue(!!profileImage);
 
       MockInteractions.tap(profileImage);
 
       return whenSelectedImageUrlChanged().then(function() {
         expectEquals(changePicture.selectedImageUrl_,
                      changePicture.profileImageUrl_);
 
         Polymer.dom.flush();
         expectTrue(profileImage.active);
+        expectFalse(changePicture.$.previewImage.hidden);
       });
     });
 
     test('select old images', function() {
       // By default there is no old image.
       var oldImage = changePicture.$$('#old-image');
       assertFalse(!!oldImage);
 
       // The promise must start listening for the property change before
       // we make the fake API call.
       var promise = whenSelectedImageUrlChanged();
 
       settings.ChangePicturePage.receiveOldImage('fake-old-image.jpg');
 
       return promise.then(function() {
         // Expect the old image to be selected once an old image is sent via
         // the native interface.
         expectEquals(changePicture.selectedImageUrl_,
                      changePicture.oldImageUrl_);
 
         Polymer.dom.flush();
         var oldImage = changePicture.$$('#old-image');
         assertTrue(!!oldImage);
         expectTrue(oldImage.active);
+        expectFalse(changePicture.$.previewImage.hidden);
       });
     });
 
     test('select first default image', function() {
       var firstDefaultImage = changePicture.$$('.default-image');
       console.log(firstDefaultImage);
       assertTrue(!!firstDefaultImage);
 
       MockInteractions.tap(firstDefaultImage);
 
       return whenSelectedImageUrlChanged().then(function() {
         // Expect the first default image to be selected.
         expectEquals(changePicture.selectedImageUrl_,
                      changePicture.defaultImages_[0].url);
 
         Polymer.dom.flush();
         expectTrue(firstDefaultImage.active);
+        expectFalse(changePicture.$.previewImage.hidden);
       });
     });
   });
 
   // Run all registered tests.
   mocha.run();
 });