chrome/browser/resources/settings/people_page/change_picture.css - Issue 1610973002: Settings People Revamp: Implement Change People preview pane

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/people_page/change_picture.css

Issue 1610973002: Settings People Revamp: Implement Change People preview pane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0072-settings-add-tests-for-cros-choose-picture

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/change_picture.html » ('j') | chrome/browser/resources/settings/people_page/change_picture.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /* Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 /* Copyright (c) 2015 The Chromium Authors. All rights reserved.

2 * Use of this source code is governed by a BSD-style license that can be	2 * Use of this source code is governed by a BSD-style license that can be

3 * found in the LICENSE file. */	3 * found in the LICENSE file. */

4	4

5 #availableIcons {	5 #availableIcons {

6 -webkit-margin-start: 16px;	6 -webkit-margin-start: 16px;

7 margin-top: 16px;	7 margin-top: 16px;

8 }	8 }

9	9

	10 #availableIcons paper-button {
	dpapad 2016/01/21 18:11:40 All other CSS classes and IDs in this file are usi All other CSS classes and IDs in this file are using this-naming-style instead of thisNamingStyle. tommycli 2016/01/21 18:47:05 Done. Show quoted text On 2016/01/21 18:11:40, dpapad wrote: > All other CSS classes and IDs in this file are using this-naming-style instead > of thisNamingStyle. Done. Dan Beam 2016/01/21 19:33:28 fwiw: I dropped the presubmit check for ids-like-t Show quoted text On 2016/01/21 18:47:05, tommycli wrote: > On 2016/01/21 18:11:40, dpapad wrote: > > All other CSS classes and IDs in this file are using this-naming-style instead > > of thisNamingStyle. > > Done. fwiw: I dropped the presubmit check for ids-like-this a while ago so this.$.idsLikeThis would be easier to do, and just updated the style guide[1]. [1] https://sites.google.com/a/chromium.org/dev/developers/web-development-style-...
	11 padding: 4px;

	12 }

	13

	14 #preview-pane {

	15 flex-shrink: 0;

	16 margin: 18px 10px 0 0;

	17 width: 228px;

	18 }

	19

	20 #preview-pane img {
	tommycli 2016/01/21 01:35:10 These CSS Changes are inspired by the existing CSS These CSS Changes are inspired by the existing CSS for old Options. The mocks haven't changed the general layout much. https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
	21 border: solid 1px #cacaca;

	22 border-radius: 4px;

	23 max-height: 220px;

	24 max-width: 220px;

	25 padding: 3px;

	26 }

	27

10 .user-image {	28 .user-image {

11 height: 64px;	29 height: 64px;

12 width: 64px;	30 width: 64px;

13 }	31 }

OLD	NEW