OLD | NEW |
1 From c7020c4c8f2e786436804819d11ca2e4b9878a5f Mon Sep 17 00:00:00 2001 | 1 From a00fdd7ed25829eb5489907fc1e4a43429e0b621 Mon Sep 17 00:00:00 2001 |
2 From: "tc@google.com" <tc@google.com> | 2 From: "tc@google.com" <tc@google.com> |
3 Date: Tue, 6 Jan 2009 22:39:41 +0000 | 3 Date: Tue, 6 Jan 2009 22:39:41 +0000 |
4 Subject: [PATCH 07/16] Custom shell.c helpers to load Chromium's ICU data. | 4 Subject: [PATCH 06/10] Custom shell.c helpers to load Chromium's ICU data. |
5 | 5 |
6 History uses fts3 with an icu-based segmenter. These changes allow building a | 6 History uses fts3 with an icu-based segmenter. These changes allow building a |
7 sqlite3 binary for Linux or Windows which can read those files. | 7 sqlite3 binary for Linux or Windows which can read those files. |
8 | 8 |
9 Original review URL: https://codereview.chromium.org/42250 | 9 Original review URL: https://codereview.chromium.org/42250 |
10 --- | 10 --- |
11 third_party/sqlite/src/Makefile.linux-gcc | 7 ++++++ | 11 third_party/sqlite/src/Makefile.linux-gcc | 7 ++++++ |
12 third_party/sqlite/src/main.mk | 2 +- | 12 third_party/sqlite/src/main.mk | 2 +- |
13 third_party/sqlite/src/src/shell.c | 10 +++++++++ | 13 third_party/sqlite/src/src/shell.c | 10 +++++++++ |
14 third_party/sqlite/src/src/shell_icu_linux.c | 27 +++++++++++++++++++++++ | 14 third_party/sqlite/src/src/shell_icu_linux.c | 27 +++++++++++++++++++++++ |
15 third_party/sqlite/src/src/shell_icu_win.c | 32 ++++++++++++++++++++++++++++ | 15 third_party/sqlite/src/src/shell_icu_win.c | 32 ++++++++++++++++++++++++++++ |
16 5 files changed, 77 insertions(+), 1 deletion(-) | 16 5 files changed, 77 insertions(+), 1 deletion(-) |
17 create mode 100644 third_party/sqlite/src/src/shell_icu_linux.c | 17 create mode 100644 third_party/sqlite/src/src/shell_icu_linux.c |
18 create mode 100644 third_party/sqlite/src/src/shell_icu_win.c | 18 create mode 100644 third_party/sqlite/src/src/shell_icu_win.c |
19 | 19 |
20 diff --git a/third_party/sqlite/src/Makefile.linux-gcc b/third_party/sqlite/src/
Makefile.linux-gcc | 20 diff --git a/third_party/sqlite/src/Makefile.linux-gcc b/third_party/sqlite/src/
Makefile.linux-gcc |
21 index e631816..f60f1a1 100644 | 21 index f6291c0..17c9e00 100644 |
22 --- a/third_party/sqlite/src/Makefile.linux-gcc | 22 --- a/third_party/sqlite/src/Makefile.linux-gcc |
23 +++ b/third_party/sqlite/src/Makefile.linux-gcc | 23 +++ b/third_party/sqlite/src/Makefile.linux-gcc |
24 @@ -86,6 +86,13 @@ OPTS += -DOS_UNIX=1 | 24 @@ -85,6 +85,13 @@ OPTS += -DOS_UNIX=1 |
25 # purposes. | 25 # purposes. |
26 OPTS += -DDEFAULT_ENABLE_RECOVER=1 | 26 OPTS += -DDEFAULT_ENABLE_RECOVER=1 |
27 | 27 |
28 +# Support for loading Chromium ICU data in sqlite3. | 28 +# Support for loading Chromium ICU data in sqlite3. |
29 +ifeq ($(shell uname -s),Darwin) | 29 +ifeq ($(shell uname -s),Darwin) |
30 +SHELL_ICU = | 30 +SHELL_ICU = |
31 +else | 31 +else |
32 +SHELL_ICU = $(TOP)/src/shell_icu_linux.c -licuuc | 32 +SHELL_ICU = $(TOP)/src/shell_icu_linux.c -licuuc |
33 +endif | 33 +endif |
34 + | 34 + |
35 #### The suffix to add to executable files. ".exe" for windows. | 35 #### The suffix to add to executable files. ".exe" for windows. |
36 # Nothing for unix. | 36 # Nothing for unix. |
37 # | 37 # |
38 diff --git a/third_party/sqlite/src/main.mk b/third_party/sqlite/src/main.mk | 38 diff --git a/third_party/sqlite/src/main.mk b/third_party/sqlite/src/main.mk |
39 index 2189fd6..54b5b35 100644 | 39 index a8629aa..4a6d5d6 100644 |
40 --- a/third_party/sqlite/src/main.mk | 40 --- a/third_party/sqlite/src/main.mk |
41 +++ b/third_party/sqlite/src/main.mk | 41 +++ b/third_party/sqlite/src/main.mk |
42 @@ -395,7 +395,7 @@ libsqlite3.a:» $(LIBOBJ) | 42 @@ -476,7 +476,7 @@ libsqlite3.a:» $(LIBOBJ) |
43 | 43 |
44 sqlite3$(EXE): $(TOP)/src/shell.c libsqlite3.a sqlite3.h | 44 sqlite3$(EXE): $(TOP)/src/shell.c libsqlite3.a sqlite3.h |
45 » $(TCCX) $(READLINE_FLAGS) -o sqlite3$(EXE) \ | 45 » $(TCCX) $(READLINE_FLAGS) -o sqlite3$(EXE) $(SHELL_OPT) \ |
46 -» » $(TOP)/src/shell.c \ | 46 -» » $(TOP)/src/shell.c libsqlite3.a $(LIBREADLINE) $(TLIBS) $(THREAD
LIB) |
47 +» » $(TOP)/src/shell.c $(SHELL_ICU) \ | 47 +» » $(TOP)/src/shell.c $(SHELL_ICU) libsqlite3.a $(LIBREADLINE) $(TL
IBS) $(THREADLIB) |
48 » » libsqlite3.a $(LIBREADLINE) $(TLIBS) $(THREADLIB) | |
49 | 48 |
50 mptester$(EXE):» sqlite3.c $(TOP)/mptest/mptest.c | 49 sqldiff$(EXE):»$(TOP)/tool/sqldiff.c sqlite3.c sqlite3.h |
| 50 » $(TCCX) -o sqldiff$(EXE) -DSQLITE_THREADSAFE=0 \ |
51 diff --git a/third_party/sqlite/src/src/shell.c b/third_party/sqlite/src/src/she
ll.c | 51 diff --git a/third_party/sqlite/src/src/shell.c b/third_party/sqlite/src/src/she
ll.c |
52 index 3ca4b09..0951481 100644 | 52 index b7a7abc..b1d5087 100644 |
53 --- a/third_party/sqlite/src/src/shell.c | 53 --- a/third_party/sqlite/src/src/shell.c |
54 +++ b/third_party/sqlite/src/src/shell.c | 54 +++ b/third_party/sqlite/src/src/shell.c |
55 @@ -3963,6 +3963,16 @@ int main(int argc, char **argv){ | 55 @@ -4645,6 +4645,16 @@ int SQLITE_CDECL main(int argc, char **argv){ |
56 signal(SIGINT, interrupt_handler); | 56 } |
57 #endif | 57 #endif |
58 | 58 |
59 + /* Begin evanm patch. */ | 59 + /* Begin evanm patch. */ |
60 +#if !defined(__APPLE__) | 60 +#if !defined(__APPLE__) |
61 + extern int sqlite_shell_init_icu(); | 61 + extern int sqlite_shell_init_icu(); |
62 + if( !sqlite_shell_init_icu() ){ | 62 + if( !sqlite_shell_init_icu() ){ |
63 + fprintf(stderr, "%s: warning: couldn't find icudt38.dll; " | 63 + fprintf(stderr, "%s: warning: couldn't find icudt38.dll; " |
64 + "queries against ICU FTS tables will fail.\n", argv[0]); | 64 + "queries against ICU FTS tables will fail.\n", argv[0]); |
65 + } | 65 + } |
66 +#endif /* !defined(__APPLE__) */ | 66 +#endif /* !defined(__APPLE__) */ |
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
134 + addr = GetProcAddress(module, ICU_DATA_SYMBOL); | 134 + addr = GetProcAddress(module, ICU_DATA_SYMBOL); |
135 + if (!addr) | 135 + if (!addr) |
136 + return 0; | 136 + return 0; |
137 + | 137 + |
138 + err = U_ZERO_ERROR; | 138 + err = U_ZERO_ERROR; |
139 + udata_setCommonData(addr, &err); | 139 + udata_setCommonData(addr, &err); |
140 + | 140 + |
141 + return 1; | 141 + return 1; |
142 +} | 142 +} |
143 -- | 143 -- |
144 2.2.1 | 144 2.7.0 |
145 | 145 |
OLD | NEW |