Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 161093002: Disable RenderViewBrowserTest.ConfirmCacheInformationPlumbed on branded builders. (Closed)

Created:
6 years, 10 months ago by Randy Smith (Not in Mondays)
Modified:
6 years, 10 months ago
Reviewers:
jamesr, Charlie Reis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Disable RenderViewBrowserTest.ConfirmCacheInformationPlumbed on branded builders. (It uses --single-process, which is disabled on branded builders.) BUG=342418 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250934

Patch Set 1 #

Patch Set 2 : Sync'd to r250709 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -226 lines) Patch
M content/content_tests.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
A content/renderer/browser_render_view_browsertest.cc View 1 chunk +254 lines, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 5 chunks +0 lines, -226 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Randy Smith (Not in Mondays)
James: PTAL?
6 years, 10 months ago (2014-02-12 20:11:37 UTC) #1
jamesr
I'm just seeing "old chunk mismatch" - could you upload again please?
6 years, 10 months ago (2014-02-12 20:14:01 UTC) #2
Randy Smith (Not in Mondays)
Sorry about that. Is this better?
6 years, 10 months ago (2014-02-12 20:26:14 UTC) #3
jamesr
lgtm as a stopgap, but what's the plan to actually fix these tests?
6 years, 10 months ago (2014-02-12 20:42:30 UTC) #4
Randy Smith (Not in Mondays)
On 2014/02/12 20:42:30, jamesr wrote: > lgtm as a stopgap, but what's the plan to ...
6 years, 10 months ago (2014-02-12 20:44:54 UTC) #5
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org
6 years, 10 months ago (2014-02-12 22:54:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/161093002/90001
6 years, 10 months ago (2014-02-12 22:58:12 UTC) #7
Randy Smith (Not in Mondays)
creis@chromium.org: Would you be willing to stamp changes in content/content_tests.gypi? James has already given his ...
6 years, 10 months ago (2014-02-12 23:10:31 UTC) #8
Randy Smith (Not in Mondays)
creis@chromium.org: Would you be willing to stamp changes in content/content_tests.gypi? James has already given his ...
6 years, 10 months ago (2014-02-12 23:10:48 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 23:25:45 UTC) #10
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=49935
6 years, 10 months ago (2014-02-12 23:25:46 UTC) #11
Charlie Reis
Sure, content/content_tests.gypi LGTM
6 years, 10 months ago (2014-02-12 23:31:59 UTC) #12
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org
6 years, 10 months ago (2014-02-12 23:33:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/161093002/90001
6 years, 10 months ago (2014-02-12 23:39:42 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 02:40:09 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263142
6 years, 10 months ago (2014-02-13 02:40:10 UTC) #16
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org
6 years, 10 months ago (2014-02-13 03:04:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/161093002/90001
6 years, 10 months ago (2014-02-13 03:05:06 UTC) #18
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 04:04:12 UTC) #19
Message was sent while issue was closed.
Change committed as 250934

Powered by Google App Engine
This is Rietveld 408576698