Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: trunk/src/chrome/browser/extensions/extension_system.cc

Issue 16109003: Revert 202751 "Change RulesRegistryService to use ProfileKeyedAPI." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/extension_system.cc
===================================================================
--- trunk/src/chrome/browser/extensions/extension_system.cc (revision 202762)
+++ trunk/src/chrome/browser/extensions/extension_system.cc (working copy)
@@ -11,6 +11,7 @@
#include "base/strings/string_tokenizer.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/content_settings/cookie_settings.h"
+#include "chrome/browser/extensions/api/declarative/rules_registry_service.h"
#include "chrome/browser/extensions/blacklist.h"
#include "chrome/browser/extensions/component_loader.h"
#include "chrome/browser/extensions/event_router.h"
@@ -287,6 +288,8 @@
}
ExtensionSystemImpl::~ExtensionSystemImpl() {
+ if (rules_registry_service_)
+ rules_registry_service_->Shutdown();
}
void ExtensionSystemImpl::Shutdown() {
@@ -310,9 +313,23 @@
usb_device_resource_manager_.reset(
new ApiResourceManager<UsbDeviceResource>(BrowserThread::IO));
+ rules_registry_service_.reset(new RulesRegistryService(profile_));
+ rules_registry_service_->RegisterDefaultRulesRegistries();
+
shared_->Init(extensions_enabled);
}
+void ExtensionSystemImpl::InitForOTRProfile() {
+ // Only initialize the RulesRegistryService of the OTR ExtensionSystem if the
+ // regular ExtensionSystem has been initialized properly, as we depend on it.
+ // Some ChromeOS browser tests don't initialize the regular ExtensionSystem
+ // in login-tests.
+ if (extension_service()) {
+ rules_registry_service_.reset(new RulesRegistryService(profile_));
+ rules_registry_service_->RegisterDefaultRulesRegistries();
+ }
+}
+
ExtensionService* ExtensionSystemImpl::extension_service() {
return shared_->extension_service();
}
@@ -349,6 +366,10 @@
return shared_->event_router();
}
+RulesRegistryService* ExtensionSystemImpl::rules_registry_service() {
+ return rules_registry_service_.get();
+}
+
ApiResourceManager<SerialConnection>*
ExtensionSystemImpl::serial_connection_manager() {
return serial_connection_manager_.get();
« no previous file with comments | « trunk/src/chrome/browser/extensions/extension_system.h ('k') | trunk/src/chrome/browser/extensions/tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698