Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 16109003: Revert 202751 "Change RulesRegistryService to use ProfileKeyedAPI." (Closed)

Created:
7 years, 6 months ago by Dan Beam
Modified:
7 years, 6 months ago
Reviewers:
Patrick Riordan
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202751 "Change RulesRegistryService to use ProfileKeyedAPI." Broke ScriptBadgeControllerTest.ExecutionMakesBadgeVisible on Linux Clang (dbg) [ RUN ] ScriptBadgeControllerTest.ExecutionMakesBadgeVisible [16238:16238:0528/195340:652289748:ERROR:activity_log.cc(168)] BrowserThread::DB does not exist, running on UI thread! Received signal 11 SEGV_MAPERR 000000000058 [0x7f664570b17e] base::debug::StackTrace::StackTrace() [0x7f664570acb7] base::debug::(anonymous namespace)::StackDumpSignalHandler() [0x7f66363facb0] <unknown> [0x0000032aa59c] extensions::RulesRegistryService::content_rules_registry() [0x0000032a8cc8] extensions::TabHelper::DidNavigateMainFrame() [0x7f663c8ca46d] content::WebContentsImpl::DidNavigateMainFramePostCommit() [0x7f663c8cba53] content::WebContentsImpl::DidNavigate() [0x7f663c8cbb97] content::WebContentsImpl::DidNavigate() [0x7f663c7d58a1] content::RenderViewHostImpl::OnNavigate() [0x000002efa9dd] content::TestRenderViewHost::SendNavigateWithParameters() [0x000002efa462] content::TestRenderViewHost::SendNavigateWithTransitionAndResponseCode() [0x000002efa4df] content::TestRenderViewHost::SendNavigateWithTransition() [0x000002efa34d] content::TestRenderViewHost::SendNavigate() [0x000002ef30d2] content::TestWebContents::CommitPendingNavigation() [0x000002ef2df3] content::TestWebContents::NavigateAndCommit() [0x000002eeb1a7] content::RenderViewHostTestHarness::NavigateAndCommit() [0x000000b9d012] extensions::(anonymous namespace)::ScriptBadgeControllerTest_ExecutionMakesBadgeVisible_Test::TestBody() [0x000003567393] testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x00000355e25e] testing::internal::HandleExceptionsInMethodIfSupported<>() [0x000003555da5] testing::Test::Run() [0x0000035564ab] testing::TestInfo::Run() [0x000003556a47] testing::TestCase::Run() [0x00000355ad75] testing::internal::UnitTestImpl::RunAllTests() [0x000003564453] testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x00000355f70e] testing::internal::HandleExceptionsInMethodIfSupported<>() [0x00000355aa64] testing::UnitTest::Run() [0x0000043d60df] base::TestSuite::Run() [0x0000042948ed] content::UnitTestTestSuite::Run() [0x00000406ad24] main [0x7f663402776d] __libc_start_main [0x0000004fbb09] <unknown> r8: 0000000000000020 r9: 0101010101010101 r10: 00007fff7dd127c0 r11: 00007f6634091d2e r12: 00000000004fbae0 r13: 00007fff7dd14f00 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000000000 si: 00007fff7dd12840 bp: 00007fff7dd12b00 bx: 0000000000606cd0 dx: 0000000000000000 ax: 0000000000000000 cx: 0000000000000001 sp: 00007fff7dd12b00 ip: 00000000032aa59c efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000058 > Change RulesRegistryService to use ProfileKeyedAPI. > > BUG=179951 > > Review URL: https://chromiumcodereview.appspot.com/13825014 TBR=patrickriordan177@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -44 lines) Patch
M trunk/src/chrome/browser/extensions/api/declarative/declarative_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/declarative/declarative_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/declarative/rules_registry_service.h View 4 chunks +2 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/declarative/rules_registry_service.cc View 3 chunks +1 line, -17 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_system.h View 7 chunks +12 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_system.cc View 4 chunks +21 lines, -0 lines 0 comments Download
MM trunk/src/chrome/browser/extensions/tab_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download
MM trunk/src/chrome/browser/extensions/tab_helper.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/test_extension_system.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/extensions/test_extension_system.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Dan Beam
7 years, 6 months ago (2013-05-29 03:23:40 UTC) #1
Dan Beam
7 years, 6 months ago (2013-05-29 03:27:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r202763.

Powered by Google App Engine
This is Rietveld 408576698