third_party/WebKit/Source/core/fetch/ImageResource.cpp - Issue 1610883002: Oilpan: ImageObserver needs to be a GC mixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.cpp

Issue 1610883002: Oilpan: ImageObserver needs to be a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit test compile fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/ImageResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.cpp b/third_party/WebKit/Source/core/fetch/ImageResource.cpp

index c4719eebb6ae4fac2d735304a0b072dd5148d392..ced5889728286b9be43366034432d789acdb9818 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/ImageResource.cpp

@@ -97,6 +97,12 @@ ImageResource::~ImageResource()

clearImage();

haraken 2016/01/20 23:24:27 Can we remove this in oilpan?

sof 2016/01/21 06:14:24 Certainly can; well spotted. Removed, but leaving

}

+DEFINE_TRACE(ImageResource)

+ Resource::trace(visitor);

+ ImageObserver::trace(visitor);

void ImageResource::load(ResourceFetcher* fetcher, const ResourceLoaderOptions& options)

{

if (!fetcher || fetcher->autoLoadImages())