Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 161083004: Update UI strings for Metro<->Desktop relaunch when apps are running. (Closed)

Created:
6 years, 10 months ago by tapted
Modified:
6 years, 10 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Update UI strings for Metro<->Desktop relaunch when apps are running. The strings currently say Chrome apps will close. Actually they will close and then relaunch in the new desktop type. BUG=315239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251314

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tapted
.. Went with "close and relaunch" instead of just "relaunch" so the potential for data ...
6 years, 10 months ago (2014-02-12 23:30:26 UTC) #1
benwells
Did this come from some UI person or something?
6 years, 10 months ago (2014-02-13 05:07:56 UTC) #2
tapted
On 2014/02/13 05:07:56, benwells wrote: > Did this come from some UI person or something? ...
6 years, 10 months ago (2014-02-13 05:18:53 UTC) #3
benwells
lgtm
6 years, 10 months ago (2014-02-14 03:52:05 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 10 months ago (2014-02-14 04:23:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/161083004/60001
6 years, 10 months ago (2014-02-14 04:24:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 04:24:32 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/app/generated_resources.grd: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-14 04:24:32 UTC) #8
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 10 months ago (2014-02-14 05:36:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/161083004/150001
6 years, 10 months ago (2014-02-14 05:37:19 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 14:54:09 UTC) #11
Message was sent while issue was closed.
Change committed as 251314

Powered by Google App Engine
This is Rietveld 408576698