Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: Source/core/dom/LiveNodeList.h

Issue 161083002: Make NodeList::ownerNode() virtual and rename to virtualOwnerNode() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reupload Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/LiveNodeList.h
diff --git a/Source/core/dom/LiveNodeList.h b/Source/core/dom/LiveNodeList.h
index 5b128c4af13428a78028a561a381314b87e63b5f..60d70b00bb2f7f661c66b620a132abcccb2a2db8 100644
--- a/Source/core/dom/LiveNodeList.h
+++ b/Source/core/dom/LiveNodeList.h
@@ -135,8 +135,6 @@ public:
virtual unsigned length() const OVERRIDE FINAL { return m_collectionIndexCache.nodeCount(*this); }
virtual Node* item(unsigned offset) const OVERRIDE FINAL { return m_collectionIndexCache.nodeAt(*this, offset); }
virtual bool nodeMatches(const Element&) const = 0;
- // Avoid ambiguity since both NodeList and LiveNodeListBase have an ownerNode() method.
- using LiveNodeListBase::ownerNode;
virtual void invalidateCache() const OVERRIDE FINAL;
bool shouldOnlyIncludeDirectChildren() const { return false; }
@@ -148,7 +146,7 @@ public:
Element* traverseForwardToOffset(unsigned offset, Element& currentNode, unsigned& currentOffset, const ContainerNode& root) const;
private:
- virtual bool isLiveNodeList() const OVERRIDE FINAL { return true; }
+ virtual Node* virtualOwnerNode() const OVERRIDE FINAL;
mutable CollectionIndexCache<LiveNodeList, Element> m_collectionIndexCache;
};

Powered by Google App Engine
This is Rietveld 408576698