chrome/browser/chromeos/login/oobe_browsertest.cc - Issue 1610823003: Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/oobe_browsertest.cc

Issue 1610823003: Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-add-supervised-user

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc ('K') | « chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc ('k') | chrome/browser/chromeos/login/oobe_localization_browsertest.cc » ('j') | chrome/browser/chromeos/login/oobe_localization_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/oobe_browsertest.cc

diff --git a/chrome/browser/chromeos/login/oobe_browsertest.cc b/chrome/browser/chromeos/login/oobe_browsertest.cc

index e566d290a69218db9c0e1891cce001ad4dfc204c..eab8ce497886c2855fb6fed862973f179e4dca30 100644

--- a/chrome/browser/chromeos/login/oobe_browsertest.cc

+++ b/chrome/browser/chromeos/login/oobe_browsertest.cc

@@ -42,7 +42,7 @@ class OobeTest : public OobeBaseTest {

void TearDownOnMainThread() override {

// If the login display is still showing, exit gracefully.

- if (LoginDisplayHostImpl::default_host()) {

+ if (LoginDisplayHost::default_host()) {

base::MessageLoop::current()->PostTask(FROM_HERE,

base::Bind(&chrome::AttemptExit));

content::RunMessageLoop();

@@ -61,7 +61,7 @@ class OobeTest : public OobeBaseTest {

views::Widget* GetLoginWindowWidget() {

return static_cast<chromeos::LoginDisplayHostImpl*>(

achuithb 2016/01/21 23:14:31 Is this static_cast necessary? Drop chromeos::

jdufault 2016/01/22 21:14:11 Yep, the cast is needed.

- chromeos::LoginDisplayHostImpl::default_host())

+ chromeos::LoginDisplayHost::default_host())

->login_window_for_test();

}