Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Side by Side Diff: tools/sk_tool_utils_font.cpp

Issue 1610823002: Consolidate SK_CRASH and sk_throw into SK_ABORT (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: windows fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/Stats.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "Resources.h" 8 #include "Resources.h"
9 #include "SkFontMgr.h" 9 #include "SkFontMgr.h"
10 #include "SkMutex.h" 10 #include "SkMutex.h"
(...skipping 24 matching lines...) Expand all
35 if (name) { 35 if (name) {
36 for (int index = 0; index < gSubFontsCount; ++index) { 36 for (int index = 0; index < gSubFontsCount; ++index) {
37 sub = &gSubFonts[index]; 37 sub = &gSubFonts[index];
38 if (!strcmp(name, sub->fName) && sub->fStyle == style) { 38 if (!strcmp(name, sub->fName) && sub->fStyle == style) {
39 fontData = &sub->fFont; 39 fontData = &sub->fFont;
40 break; 40 break;
41 } 41 }
42 } 42 }
43 if (!fontData) { 43 if (!fontData) {
44 // Once all legacy callers to portable fonts are converted, replace this with 44 // Once all legacy callers to portable fonts are converted, replace this with
45 // SK_CRASH(); 45 // SK_ABORT();
46 SkDebugf("missing %s %d\n", name, style); 46 SkDebugf("missing %s %d\n", name, style);
47 // If we called SkTypeface::CreateFromName() here we'd recurse infin itely, 47 // If we called SkTypeface::CreateFromName() here we'd recurse infin itely,
48 // so we reimplement its core logic here inline without the recursiv e aspect. 48 // so we reimplement its core logic here inline without the recursiv e aspect.
49 SkAutoTUnref<SkFontMgr> fm(SkFontMgr::RefDefault()); 49 SkAutoTUnref<SkFontMgr> fm(SkFontMgr::RefDefault());
50 return fm->legacyCreateTypeface(name, style); 50 return fm->legacyCreateTypeface(name, style);
51 } 51 }
52 } else { 52 } else {
53 sub = &gSubFonts[gDefaultFontIndex]; 53 sub = &gSubFonts[gDefaultFontIndex];
54 fontData = &sub->fFont; 54 fontData = &sub->fFont;
55 } 55 }
56 SkTestFont* font; 56 SkTestFont* font;
57 { 57 {
58 SkAutoMutexAcquire ac(gTestFontMutex); 58 SkAutoMutexAcquire ac(gTestFontMutex);
59 if (fontData->fFontCache) { 59 if (fontData->fFontCache) {
60 font = SkSafeRef(fontData->fFontCache); 60 font = SkSafeRef(fontData->fFontCache);
61 } else { 61 } else {
62 font = new SkTestFont(*fontData); 62 font = new SkTestFont(*fontData);
63 SkDEBUGCODE(font->fDebugName = sub->fName); 63 SkDEBUGCODE(font->fDebugName = sub->fName);
64 SkDEBUGCODE(font->fDebugStyle = sub->fStyle); 64 SkDEBUGCODE(font->fDebugStyle = sub->fStyle);
65 fontData->fFontCache = SkSafeRef(font); 65 fontData->fFontCache = SkSafeRef(font);
66 } 66 }
67 } 67 }
68 return new SkTestTypeface(font, SkFontStyle(style)); 68 return new SkTestTypeface(font, SkFontStyle(style));
69 } 69 }
70 70
71 } 71 }
OLDNEW
« no previous file with comments | « tools/Stats.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698