Avoid parsing path and query string more than once

tests/corelib/uri_query_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 
 void testInvalidArguments() {
 }
 
 void testEncodeQueryComponent() {
@@ skipping 53 matching lines @@
     } else if (unreserved.indexOf(new String.fromCharCode(i)) != -1) {
       encoded.writeCharCode(i);
     } else {
       encoded.write("%");
       encoded.write(i.toRadixString(16).toUpperCase());
     }
     unencoded.writeCharCode(i);
   }
   encoded = encoded.toString();
   unencoded = unencoded.toString();
-  print(encoded);
-  print(unencoded);
   test("a=$encoded", {"a": unencoded});
   test("a=$encoded&b=$encoded", {"a": unencoded, "b": unencoded});
 
   var map = new Map();
   map[unencoded] = unencoded;
   test("$encoded=$encoded", map);
 }
 
 testInvalidQueryParameters() {
   test(String query, Map<String, String> parameters) {
@@ skipping 20 matching lines @@
   test("=", {});
   test("=xxx", {});
   test("===", {});
   test("=xxx=yyy=zzz", {});
   test("=&=&=", {});
   test("=xxx&=yyy&=zzz", {});
   test("&=&=&", {});
   test("&=xxx&=xxx&", {});
 }
 
+testQueryParametersParsedOnce() {
+  var uri = Uri.parse("?a=b&c=d");
+  Expect.isTrue(identical(uri.queryParameters, uri.queryParameters));

[Lasse Reichstein Nielsen, 2013/05/30 11:57:50]

Ditto here, don't specify it and don't test for it, just optimize and run!

[Søren Gjesse, 2013/05/30 13:38:25]

Done.

+
+  var map = {"a": "b", "c": "d"};
+  uri = new Uri(queryParameters: map);
+  Expect.isFalse(identical(map, uri.queryParameters));
+  Expect.isTrue(identical(uri.queryParameters, uri.queryParameters));
+}
+
 main() {
   testInvalidArguments();
   testEncodeQueryComponent();
   testQueryParameters();
   testInvalidQueryParameters();
+  testQueryParametersParsedOnce();
 }