Avoid parsing path and query string more than once

sdk/lib/core/uri.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.core;
 
 /**
  * A parsed URI, as specified by RFC-3986, http://tools.ietf.org/html/rfc3986.
  */
 class Uri {
@@ skipping 63 matching lines @@
   final String query;
 
   /**
    * Returns the fragment identifier component.
    *
    * Returns the empty string if there is no fragment identifier
    * component.
    */
   final String fragment;
 
+  List<String> _pathSegments;

[Lasse Reichstein Nielsen, 2013/05/30 11:57:50]

Dartdoc saying that this caches the computed return value of [pathSegments].

[Søren Gjesse, 2013/05/30 13:38:25]

Done.

+  Map<String, String> _queryParameters;

[Lasse Reichstein Nielsen, 2013/05/30 11:57:50]

Similar.

[Søren Gjesse, 2013/05/30 13:38:25]

Done.

+
   /**
    * Creates a new URI object by parsing a URI string.
    */
   static Uri parse(String uri) => new Uri._fromMatch(_splitRe.firstMatch(uri));
 
   Uri._fromMatch(Match m) :
     this(scheme: _emptyIfNull(m[_COMPONENT_SCHEME]),
          userInfo: _emptyIfNull(m[_COMPONENT_USER_INFO]),
          host: _eitherOf(
          m[_COMPONENT_HOST], m[_COMPONENT_HOST_IPV6]),
@@ skipping 66 matching lines @@
       _port = 0;
     } else {
       _port = port;
     }
   }
 
   /*
    * Returns the URI path split into its segments. Each of the
    * segments in the returned list have been decoded. If the path is
    * empty the empty list will be returned.
+   *
+   * The returned list should not be modified as the same object will
+   * be returned for each call.

[Lasse Reichstein Nielsen, 2013/05/30 11:57:50]

"should not" isn't very safe. Could you make it unmodifiable?

[Søren Gjesse, 2013/05/30 13:38:25]

Created an immutable list wrapper.

    */
   List<String> get pathSegments {
-    if (path == "") return const<String>[];
-    return path.split("/").map(Uri.decodeComponent).toList(growable: false);
+    if (_pathSegments == null) {
+      _pathSegments =
+        path == "" ? const<String>[]
+                   : path.split("/")
+                         .map(Uri.decodeComponent)
+                         .toList(growable: false);
+    }
+    return _pathSegments;
   }
 
   /*
    * Returns the URI query split into a map according to the rules
    * specified for FORM post in the HTML 4.01 specification. Each key
    * and value in the returned map have been decoded. If there is no
    * query the empty map will be returned.
+   *
+   * The returned map should not be modified as the same object will
+   * be returned for each call.
    */
   Map<String, String> get queryParameters {
-    return query.split("&").fold({}, (map, element) {
+    if (_queryParameters == null) {
+      _queryParameters = query.split("&").fold({}, (map, element) {
         int index = element.indexOf("=");
         if (index == -1) {
           if (!element.isEmpty) map[element] = "";
         } else if (index != 0) {
           var key = element.substring(0, index);
           var value = element.substring(index + 1);
           map[Uri.decodeQueryComponent(key)] = decodeQueryComponent(value);
         }
         return map;
-    });
+      });
+    }
+    return _queryParameters;
   }
 
   static String _makeScheme(String scheme) {
     bool isSchemeLowerCharacter(int ch) {
       return ch < 128 &&
              ((_schemeLowerTable[ch >> 4] & (1 << (ch & 0x0f))) != 0);
     }
 
     bool isSchemeCharacter(int ch) {
       return ch < 128 && ((_schemeTable[ch >> 4] & (1 << (ch & 0x0f))) != 0);
@@ skipping 733 matching lines @@
       0xafff,   // 0x30 - 0x3f  1111111111110101
                 //              @ABCDEFGHIJKLMNO
       0xffff,   // 0x40 - 0x4f  1111111111111111
                 //              PQRSTUVWXYZ    _
       0x87ff,   // 0x50 - 0x5f  1111111111100001
                 //               abcdefghijklmno
       0xfffe,   // 0x60 - 0x6f  0111111111111111
                 //              pqrstuvwxyz   ~
       0x47ff];  // 0x70 - 0x7f  1111111111100010
 }