Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1610773003: Issue 25538. Fix for notification and private methods. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -49 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 6 chunks +62 lines, -48 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_overrides_test.dart View 2 chunks +33 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-21 03:05:49 UTC) #1
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-21 05:03:48 UTC) #2
scheglov
4 years, 11 months ago (2016-01-21 16:01:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5dc34340a1abf27df6174fcdc39f4efc0b842f18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698