drive: Stop returning FilePath from GetResourceEntryById

drive: Stop returning FilePath from GetResourceEntryById

ResourceMetadata::GetResourceEntryById no longer returns FilePath.
FileSystemInterface::GetResourceEntryById no longer returns FilePath.
Remove GetFilePath related code from FakeFileSystem.

BUG=244135
TEST=unit_tests
R=satorux@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203075

[satorux1, 2013-05-29 06:07:02]

https://codereview.chromium.org/16107004/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system.cc (right):

https://codereview.chromium.org/16107004/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system.cc:388:
base::Bind(&internal::ResourceMetadata::GetFilePath,
This seems to be awkward. Why do we need to convert a resource ID to a file path
to get a file? IIRC, we use a resource ID to download a file from the server,
and use a resource ID to get a file from the file cache. If so, we don't need to
use a file path at all here.

https://codereview.chromium.org/16107004/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system.cc:413: file_path,
My feeling is that this function taking |file_path| is questionable. Can this
take a resource ID instead? If it's easy enough, you might want to fix this
problem in a separate patch beforehand.

[hashimoto, 2013-05-30 03:45:02]

New patch with the trunk after r203040 gets landed.
PTAL

https://codereview.chromium.org/16107004/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system.cc (right):

https://codereview.chromium.org/16107004/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system.cc:413: file_path,
On 2013/05/29 06:07:03, satorux1 wrote:
> My feeling is that this function taking |file_path| is questionable. Can this
> take a resource ID instead? If it's easy enough, you might want to fix this
> problem in a separate patch beforehand.

Done.

https://codereview.chromium.org/16107004/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system.cc:413: file_path,
On 2013/05/29 06:07:03, satorux1 wrote:
> My feeling is that this function taking |file_path| is questionable. Can this
> take a resource ID instead? If it's easy enough, you might want to fix this
> problem in a separate patch beforehand.

Done.

[satorux1, 2013-05-30 03:48:44]

LGTM. looks simpler!

[hashimoto, 2013-05-30 05:01:28]

Committed patchset #2 manually as r203075 (presubmit successful).