Issue 16107003: Fix compilation error of nacl_listener.cc on VS2012

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16107003: Fix compilation error of nacl_listener.cc on VS2012 (Closed)

Created:
7 years, 6 months ago by yosin_UTC9

Modified:
7 years, 6 months ago

Reviewers:
Nick Bray (chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

This patch fixes following compilation introduced by r202702 on VS2012 d:\src\w\crbk\src\chrome\nacl\nacl_listener.cc(149) : error C2220: warning treated as error - no 'object' file generated d:\src\w\crbk\src\chrome\nacl\nacl_listener.cc(149) : warning C4703: potentially uninitialized local pointer variable 'ipc_fd' used NOTRY=true TBR=ncbray@chromium.org BUG=n/a Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202745

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/nacl/nacl_listener.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yosin_UTC9

Committed patchset #1 manually as r202745 (presubmit successful).

7 years, 6 months ago (2013-05-29 02:19:01 UTC) #1

Nick Bray (chromium)

7 years, 6 months ago (2013-05-29 02:55:59 UTC) #2

Message was sent while issue was closed.

LGTM

Thanks, this has been a cursed CL.  I swear the trybots were green - this may
have been a merge error...

Expand Messages | Collapse Messages