Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Issue 1610653002: Integrate the account chooser dialog on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
index 1204dbac9078ef7f9b4f48b286ec79030ac9ca0c..597de2c0b9723702bf27dbc7d18272941c66bdfd 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
@@ -453,123 +453,6 @@ TEST_F(ManagePasswordsUIControllerTest, AutomaticPasswordSave) {
ExpectIconStateIs(password_manager::ui::MANAGE_STATE);
}
-#if defined(OS_MACOSX)
-// TODO(vasilii): remove once Mac supports the account chooser dialog.
-TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialLocal) {
- ScopedVector<autofill::PasswordForm> local_credentials;
- local_credentials.push_back(new autofill::PasswordForm(test_local_form()));
- ScopedVector<autofill::PasswordForm> federated_credentials;
- GURL origin("http://example.com");
- EXPECT_TRUE(controller()->OnChooseCredentials(
- std::move(local_credentials), std::move(federated_credentials), origin,
- base::Bind(&ManagePasswordsUIControllerTest::CredentialCallback,
- base::Unretained(this))));
- EXPECT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE,
- controller()->GetState());
- EXPECT_EQ(origin, controller()->GetOrigin());
- EXPECT_THAT(controller()->GetCurrentForms(),
- ElementsAre(Pointee(test_local_form())));
-
- ExpectIconStateIs(password_manager::ui::CREDENTIAL_REQUEST_STATE);
-
- controller()->ManagePasswordsUIController::ChooseCredential(
- test_local_form(),
- password_manager::CredentialType::CREDENTIAL_TYPE_PASSWORD);
- controller()->OnBubbleHidden();
- EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->GetState());
- ASSERT_TRUE(credential_info());
- EXPECT_EQ(test_local_form().username_value, credential_info()->id);
- EXPECT_EQ(test_local_form().password_value, credential_info()->password);
- EXPECT_TRUE(credential_info()->federation.is_empty());
- EXPECT_EQ(password_manager::CredentialType::CREDENTIAL_TYPE_PASSWORD,
- credential_info()->type);
-}
-
-TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialLocalButFederated) {
- ScopedVector<autofill::PasswordForm> local_credentials;
- local_credentials.push_back(
- new autofill::PasswordForm(test_federated_form()));
- ScopedVector<autofill::PasswordForm> federated_credentials;
- GURL origin("http://example.com");
- EXPECT_TRUE(controller()->OnChooseCredentials(
- std::move(local_credentials), std::move(federated_credentials), origin,
- base::Bind(&ManagePasswordsUIControllerTest::CredentialCallback,
- base::Unretained(this))));
- EXPECT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE,
- controller()->GetState());
- EXPECT_EQ(origin, controller()->GetOrigin());
- EXPECT_THAT(controller()->GetCurrentForms(),
- ElementsAre(Pointee(test_federated_form())));
-
- ExpectIconStateIs(password_manager::ui::CREDENTIAL_REQUEST_STATE);
-
- controller()->ManagePasswordsUIController::ChooseCredential(
- test_federated_form(),
- password_manager::CredentialType::CREDENTIAL_TYPE_PASSWORD);
- controller()->OnBubbleHidden();
- EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->GetState());
- ASSERT_TRUE(credential_info());
- EXPECT_EQ(test_federated_form().username_value, credential_info()->id);
- EXPECT_EQ(test_federated_form().federation_url,
- credential_info()->federation);
- EXPECT_TRUE(credential_info()->password.empty());
- EXPECT_EQ(password_manager::CredentialType::CREDENTIAL_TYPE_FEDERATED,
- credential_info()->type);
-}
-
-TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialFederated) {
- ScopedVector<autofill::PasswordForm> local_credentials;
- ScopedVector<autofill::PasswordForm> federated_credentials;
- federated_credentials.push_back(
- new autofill::PasswordForm(test_local_form()));
- GURL origin("http://example.com");
- EXPECT_TRUE(controller()->OnChooseCredentials(
- std::move(local_credentials), std::move(federated_credentials), origin,
- base::Bind(&ManagePasswordsUIControllerTest::CredentialCallback,
- base::Unretained(this))));
- EXPECT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE,
- controller()->GetState());
- EXPECT_EQ(0u, controller()->GetCurrentForms().size());
- EXPECT_EQ(origin, controller()->GetOrigin());
-
- ExpectIconStateIs(password_manager::ui::CREDENTIAL_REQUEST_STATE);
-
- controller()->ManagePasswordsUIController::ChooseCredential(
- test_local_form(),
- password_manager::CredentialType::CREDENTIAL_TYPE_FEDERATED);
- controller()->OnBubbleHidden();
- EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->GetState());
- ASSERT_TRUE(credential_info());
- EXPECT_EQ(test_local_form().username_value, credential_info()->id);
- EXPECT_TRUE(credential_info()->password.empty());
- EXPECT_EQ(password_manager::CredentialType::CREDENTIAL_TYPE_FEDERATED,
- credential_info()->type);
-}
-
-TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialCancel) {
- ScopedVector<autofill::PasswordForm> local_credentials;
- local_credentials.push_back(new autofill::PasswordForm(test_local_form()));
- ScopedVector<autofill::PasswordForm> federated_credentials;
- GURL origin("http://example.com");
- EXPECT_TRUE(controller()->OnChooseCredentials(
- std::move(local_credentials), std::move(federated_credentials), origin,
- base::Bind(&ManagePasswordsUIControllerTest::CredentialCallback,
- base::Unretained(this))));
- EXPECT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE,
- controller()->GetState());
- EXPECT_EQ(origin, controller()->GetOrigin());
- controller()->ManagePasswordsUIController::ChooseCredential(
- test_local_form(),
- password_manager::CredentialType::CREDENTIAL_TYPE_EMPTY);
- controller()->OnBubbleHidden();
- EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->GetState());
- ASSERT_TRUE(credential_info());
- EXPECT_TRUE(credential_info()->federation.is_empty());
- EXPECT_TRUE(credential_info()->password.empty());
- EXPECT_EQ(password_manager::CredentialType::CREDENTIAL_TYPE_EMPTY,
- credential_info()->type);
-}
-#else // defined(OS_MACOSX)
TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialLocal) {
ScopedVector<autofill::PasswordForm> local_credentials;
local_credentials.push_back(new autofill::PasswordForm(test_local_form()));
@@ -700,7 +583,6 @@ TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialCancel) {
EXPECT_EQ(password_manager::CredentialType::CREDENTIAL_TYPE_EMPTY,
credential_info()->type);
}
-#endif // defined(OS_MACOSX)
TEST_F(ManagePasswordsUIControllerTest, AutoSignin) {
ScopedVector<autofill::PasswordForm> local_credentials;

Powered by Google App Engine
This is Rietveld 408576698