Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7020)

Unified Diff: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h

Issue 1610653002: Integrate the account chooser dialog on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h
diff --git a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h
index 5ca1d70d2ee61473f2e2d774ce58debe0f79f2c5..750ba63f025b641c8a924056b964d88becdddae8 100644
--- a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h
+++ b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h
@@ -8,13 +8,15 @@
#import <Cocoa/Cocoa.h>
#include "base/mac/scoped_nsobject.h"
-#import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h"
#import "chrome/browser/ui/cocoa/passwords/credential_item_view.h"
@class AccountAvatarFetcherManager;
-@class BubbleCombobox;
-class ManagePasswordsBubbleModel;
-@class ManagePasswordCredentialItemViewController;
+
+class PasswordDialogController;
+
+namespace net {
+class URLRequestContextGetter;
+}
// A custom cell that displays a credential item in an NSTableView.
@interface CredentialItemCell : NSCell
@@ -22,25 +24,50 @@ class ManagePasswordsBubbleModel;
@property(nonatomic, readonly) CredentialItemView* view;
@end
+// An interface for the bridge between AccountChooserViewController and platform
+// independent UI code.
+class AccountChooserBridge {
+ public:
+ // Closes the dialog.
+ virtual void PerformClose() = 0;
+
+ // Returns the controller containing the data.
+ virtual PasswordDialogController* GetDialogController() = 0;
+
+ // Returns the request context for fetching the avatars.
+ virtual net::URLRequestContextGetter* GetRequestContext() const = 0;
+
+ protected:
+ virtual ~AccountChooserBridge() = default;
+};
+
// Manages a view that shows a list of credentials that can be used for
// authentication to a site.
-@interface ManagePasswordsBubbleAccountChooserViewController
- : ManagePasswordsBubbleContentViewController<CredentialItemDelegate,
- NSTableViewDataSource,
- NSTableViewDelegate> {
+@interface AccountChooserViewController
+ : NSViewController<CredentialItemDelegate,
+ NSTableViewDataSource,
+ NSTableViewDelegate,
+ NSTextViewDelegate> {
@private
- ManagePasswordsBubbleModel* model_; // Weak.
+ AccountChooserBridge* bridge_; // Weak.
NSButton* cancelButton_; // Weak.
- BubbleCombobox* moreButton_; // Weak.
NSTableView* credentialsView_; // Weak.
+ NSTextView* titleView_; // Weak.
base::scoped_nsobject<NSArray> credentialItems_;
base::scoped_nsobject<AccountAvatarFetcherManager> avatarManager_;
}
// Initializes a new account chooser and populates it with the credentials
-// stored in |model|. Designated initializer.
-- (id)initWithModel:(ManagePasswordsBubbleModel*)model
- delegate:(id<ManagePasswordsBubbleContentViewDelegate>)delegate;
+// stored in |bridge->controller()|.
+- (id)initWithBridge:(AccountChooserBridge*)bridge;
+@end
+
+@interface AccountChooserViewController(Testing)
+- (id)initWithBridge:(AccountChooserBridge*)bridge
+ avatarManager:(AccountAvatarFetcherManager*)avatarManager;
+@property(nonatomic, readonly) NSButton* cancelButton;
+@property(nonatomic, readonly) NSTableView* credentialsView;
+@property(nonatomic, readonly) NSTextView* titleView;
@end
#endif // CHROME_BROWSER_UI_COCOA_PASSWORDS_ACCOUNT_CHOOSER_VIEW_CONTROLLER_H_
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698