Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1610603002: Simplify LayoutSVGRoot::computeReplacedLogical{Width,Height} (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify LayoutSVGRoot::computeReplacedLogical{Width,Height} Remove redundant if statements and slightly confusing comments. SVGImage unconditionally sets the container size in SVGImage::drawForContainer() so when SVGImageForContainer is used, the container size will be set. BUG=468897 Committed: https://crrev.com/e740db6e6c55027e1e117eb1e65110f8ab523363 Cr-Commit-Position: refs/heads/master@{#370393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610603002/1
4 years, 11 months ago (2016-01-20 12:52:57 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 14:32:09 UTC) #4
davve
Another small clean-up.
4 years, 11 months ago (2016-01-20 15:03:13 UTC) #5
davve
+fs for actual review.
4 years, 11 months ago (2016-01-20 15:03:41 UTC) #7
fs
lgtm
4 years, 11 months ago (2016-01-20 15:08:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610603002/1
4 years, 11 months ago (2016-01-20 15:08:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 15:13:22 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 15:14:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e740db6e6c55027e1e117eb1e65110f8ab523363
Cr-Commit-Position: refs/heads/master@{#370393}

Powered by Google App Engine
This is Rietveld 408576698