Issue 16106002: Modify UI and logic in Reset Profile dialog

Issue 16106002: Modify UI and logic in Reset Profile dialog (Closed)

Created:
7 years, 7 months ago by vasilii

Modified:
7 years, 6 months ago

Reviewers:
Dan Beam, battre

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Hide unimplemented stuff in Reset Profile dialog. Reset startup page along with home page. BUG=235037 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202861

Patch Set 2 : Use HTML5 'hidden' attribute #

Patch Set 3 : 'Reset homepage' => 'Reset startup page' #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/reset_profile_settings_overlay.html	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/reset_profile_settings_handler.cc	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

battre

https://codereview.chromium.org/16106002/diff/1/chrome/browser/resources/options/reset_profile_settings_overlay.css File chrome/browser/resources/options/reset_profile_settings_overlay.css (right): https://codereview.chromium.org/16106002/diff/1/chrome/browser/resources/options/reset_profile_settings_overlay.css#newcode22 chrome/browser/resources/options/reset_profile_settings_overlay.css:22: } Please have a look at the usage of ...

7 years, 7 months ago (2013-05-27 13:31:56 UTC) #2

vasilii

7 years, 7 months ago (2013-05-27 13:42:16 UTC) #3

battre

LGTM but it may make sense to discuss with the UX people now.

7 years, 6 months ago (2013-05-28 13:08:00 UTC) #6

Dan Beam

lgtm, but when is the time you want to re-enable this code? can we track ...

7 years, 6 months ago (2013-05-28 19:13:30 UTC) #7

vasilii

On 2013/05/28 19:13:30, Dan Beam wrote: > lgtm, but when is the time you want ...

7 years, 6 months ago (2013-05-29 09:38:21 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/16106002/13001

7 years, 6 months ago (2013-05-29 11:34:41 UTC) #9

Dan Beam

On 2013/05/29 09:38:21, vasilii wrote: > On 2013/05/28 19:13:30, Dan Beam wrote: > > lgtm, ...

7 years, 6 months ago (2013-05-29 18:37:23 UTC) #11

vasilii

7 years, 6 months ago (2013-05-31 07:34:38 UTC) #12

Message was sent while issue was closed.

On 2013/05/29 18:37:23, Dan Beam wrote:
> On 2013/05/29 09:38:21, vasilii wrote:
> > On 2013/05/28 19:13:30, Dan Beam wrote:
> > > lgtm, but when is the time you want to re-enable this code?  can we track
> this
> > > somehow?
> > 
> > We are to enable them one by one as soon as backend is ready.
> 
> where is the tracking bug?

235037. We are negotiating UI now. There is a growing probability that we'll
have to revert all the dialog.

Expand Messages | Collapse Messages