Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1610573004: Replace use of SkLerpXfermode with SkArithmeticMode (Closed)

Created:
4 years, 11 months ago by robertphillips
Modified:
4 years, 11 months ago
Reviewers:
sadrul, egdaniel, egdaniel1
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace use of SkLerpXfermode with SkArithmeticMode SkLerpXermode is going away. The same functionality can be achieved with SkArithmeticMode. Committed: https://crrev.com/edf45fdf897e88f4bd32343d93d0adffc3594b94 Cr-Commit-Position: refs/heads/master@{#370692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ui/views/controls/button/label_button_border.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
robertphillips
4 years, 11 months ago (2016-01-20 18:32:23 UTC) #3
egdaniel
lgtm
4 years, 11 months ago (2016-01-20 19:52:51 UTC) #5
sadrul
stamp lgtm
4 years, 11 months ago (2016-01-20 23:20:44 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610573004/1
4 years, 11 months ago (2016-01-21 12:58:46 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 13:54:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610573004/1
4 years, 11 months ago (2016-01-21 14:14:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 14:18:44 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 14:19:32 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edf45fdf897e88f4bd32343d93d0adffc3594b94
Cr-Commit-Position: refs/heads/master@{#370692}

Powered by Google App Engine
This is Rietveld 408576698