Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 1610553003: Remove unused arguments of blink::PopupMenu::show(). (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 11 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused arguments of blink::PopupMenu::show(). This CL has no behavior changes. Committed: https://crrev.com/173b325c19b41f03c26b94bec2db5d32e2c4ee01 Cr-Commit-Position: refs/heads/master@{#371181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PopupMenu.h View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
tkent
Keishi, would you review this please?
4 years, 11 months ago (2016-01-20 13:08:00 UTC) #2
keishi
LGTM
4 years, 11 months ago (2016-01-21 05:36:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610553003/1
4 years, 11 months ago (2016-01-21 05:50:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 05:58:09 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fe9b3fb0d905a64db165cabe933d6dc2fe872dc4 Cr-Commit-Position: refs/heads/master@{#370634}
4 years, 11 months ago (2016-01-21 05:59:27 UTC) #8
tkent
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1613783003/ by tkent@chromium.org. ...
4 years, 11 months ago (2016-01-21 09:50:10 UTC) #9
tkent
Land this again as is.
4 years, 11 months ago (2016-01-25 01:49:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610553003/1
4 years, 11 months ago (2016-01-25 01:50:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 03:18:19 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 03:20:07 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/173b325c19b41f03c26b94bec2db5d32e2c4ee01
Cr-Commit-Position: refs/heads/master@{#371181}

Powered by Google App Engine
This is Rietveld 408576698