content/renderer/media/video_track_recorder_unittest.cc - Issue 1610473002: MediaRecorder: wire the bitRate settings in Blink and content (2nd go)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/video_track_recorder_unittest.cc

Issue 1610473002: MediaRecorder: wire the bitRate settings in Blink and content (2nd go) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed. Added TODO for unsigned->signed change Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/audio_track_recorder.cc ('K') | « content/renderer/media/video_track_recorder.cc ('k') | third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-bitrates.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/video_track_recorder_unittest.cc

diff --git a/content/renderer/media/video_track_recorder_unittest.cc b/content/renderer/media/video_track_recorder_unittest.cc

index 6605bb6c31dce10b9445a14efac3368bea98368d..bf3e3717ea0072737606fd535346b2361d7ac2e5 100644

--- a/content/renderer/media/video_track_recorder_unittest.cc

+++ b/content/renderer/media/video_track_recorder_unittest.cc

@@ -67,10 +67,10 @@ class VideoTrackRecorderTest : public TestWithParam<TrackRecorderTestParams> {

blink_track_.setExtraData(track_);

video_track_recorder_.reset(new VideoTrackRecorder(

- GetParam().use_vp9 /* use_vp9 */,

- blink_track_,

+ GetParam().use_vp9 /* use_vp9 */, blink_track_,

base::Bind(&VideoTrackRecorderTest::OnEncodedVideo,

- base::Unretained(this))));

+ base::Unretained(this)),

+ 0 /* bits_per_second */));

// Paranoia checks.

EXPECT_EQ(blink_track_.source().extraData(), blink_source_.extraData());

EXPECT_TRUE(message_loop_.IsCurrent());