content/renderer/media/media_recorder_handler_unittest.cc - Issue 1610473002: MediaRecorder: wire the bitRate settings in Blink and content (2nd go)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_recorder_handler_unittest.cc

Issue 1610473002: MediaRecorder: wire the bitRate settings in Blink and content (2nd go) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed. Added TODO for unsigned->signed change Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/audio_track_recorder.cc ('K') | « content/renderer/media/media_recorder_handler.cc ('k') | content/renderer/media/video_track_recorder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_recorder_handler_unittest.cc

diff --git a/content/renderer/media/media_recorder_handler_unittest.cc b/content/renderer/media/media_recorder_handler_unittest.cc

index 6989ca68adef2886d764f313243161cfc61a41fc..4a92b223b26d5d55755dd62eeadb3999f94916b6 100644

--- a/content/renderer/media/media_recorder_handler_unittest.cc

+++ b/content/renderer/media/media_recorder_handler_unittest.cc

@@ -181,10 +181,8 @@ TEST_P(MediaRecorderHandlerTest, InitializeStartStop) {

AddTracks();

const WebString mime_type(base::UTF8ToUTF16(GetParam().mime_type));

const WebString codecs(base::UTF8ToUTF16(GetParam().codecs));

- EXPECT_TRUE(media_recorder_handler_->initialize(this,

- registry_.test_stream(),

- mime_type,

- codecs));

+ EXPECT_TRUE(media_recorder_handler_->initialize(this, registry_.test_stream(),

+ mime_type, codecs, 0, 0));

EXPECT_FALSE(recording());

EXPECT_FALSE(hasVideoRecorders());

EXPECT_FALSE(hasAudioRecorders());

@@ -216,7 +214,7 @@ TEST_P(MediaRecorderHandlerTest, EncodeVideoFrames) {

const WebString mime_type(base::UTF8ToUTF16(GetParam().mime_type));

const WebString codecs(base::UTF8ToUTF16(GetParam().codecs));

EXPECT_TRUE(media_recorder_handler_->initialize(this, registry_.test_stream(),

- mime_type, codecs));

+ mime_type, codecs, 0, 0));

EXPECT_TRUE(media_recorder_handler_->start());

InSequence s;

@@ -275,8 +273,8 @@ TEST_P(MediaRecorderHandlerTest, EncodeAudioFrames) {

AddTracks();

const WebString mime_type(base::UTF8ToUTF16("audio/webm"));

- EXPECT_TRUE(media_recorder_handler_->initialize(this, registry_.test_stream(),

- mime_type, WebString()));

+ EXPECT_TRUE(media_recorder_handler_->initialize(

+ this, registry_.test_stream(), mime_type, WebString(), 0, 0));

EXPECT_TRUE(media_recorder_handler_->start());

InSequence s;