content/renderer/media/media_recorder_handler.h - Issue 1610473002: MediaRecorder: wire the bitRate settings in Blink and content (2nd go)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_recorder_handler.h

Issue 1610473002: MediaRecorder: wire the bitRate settings in Blink and content (2nd go) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed. Added TODO for unsigned->signed change Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/audio_track_recorder.cc ('K') | « content/renderer/media/audio_track_recorder_unittest.cc ('k') | content/renderer/media/media_recorder_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_recorder_handler.h

diff --git a/content/renderer/media/media_recorder_handler.h b/content/renderer/media/media_recorder_handler.h

index cc50c84ee84c9a371a423581f5faa614f16a9dca..1e31a5f5c9c7a1902ea837f29f1ce131b7300ca7 100644

--- a/content/renderer/media/media_recorder_handler.h

+++ b/content/renderer/media/media_recorder_handler.h

@@ -53,7 +53,9 @@ class CONTENT_EXPORT MediaRecorderHandler final

bool initialize(blink::WebMediaRecorderHandlerClient* client,

const blink::WebMediaStream& media_stream,

const blink::WebString& type,

- const blink::WebString& codecs) override;

+ const blink::WebString& codecs,

+ int32_t audio_bits_per_second,

+ int32_t video_bits_per_second) override;

bool start() override;

bool start(int timeslice) override;

void stop() override;

@@ -81,6 +83,10 @@ class CONTENT_EXPORT MediaRecorderHandler final

// Bound to the main render thread.

base::ThreadChecker main_render_thread_checker_;

+ // Sanitized video and audio bitrate settings passed on initialize().

+ int32_t video_bits_per_second_;

+ int32_t audio_bits_per_second_;

// Force using VP9 for video encoding, otherwise VP8 will be used by default.

bool use_vp9_;