chrome/browser/resources/user_chooser/user_chooser.html - Issue 16104008: First try at a user management screen for the desktop

Side by Side Diff: chrome/browser/resources/user_chooser/user_chooser.html

Issue 16104008: First try at a user management screen for the desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/login/user_pod_row.js ('k') | chrome/browser/resources/user_chooser/user_chooser.js » ('j') | chrome/browser/resources/user_chooser/user_chooser.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html i18n-values="dir:textdirection;screen:screenType;build:buildType">

	3 <head>

	4 <title i18n-content="title"></title>

	5 <link rel="stylesheet" href="../chromeos/login/oobe.css">

	6 <link rel="stylesheet" href="../chromeos/login/user_pod_row.css">

	7 <link rel="stylesheet" href="../chromeos/login/header_bar.css">

	8 <!-- desktop user chooser specific overrides -->

	9 <link rel="stylesheet" href="control_bar.css">

	10 <link rel="stylesheet" href="../chromeos/login/bubble.css">

	11 <link rel="stylesheet" href="../chromeos/login/screen_account_picker.css">

	12 <link rel="stylesheet" href="../chromeos/login/screen_container.css">

	13 <!-- framework imports -->

	14 <!-- as per chrome/browser/resources/chromeos/login/login_resources.html -->

	15 <script src="chrome://resources/js/cr.js"></script>

	16 <script src="chrome://resources/js/event_tracker.js"></script>

	17 <script src="chrome://resources/js/cr/event_target.js"></script>

	18 <script src="chrome://resources/js/cr/ui.js"></script>

	19 <script src="chrome://resources/js/cr/ui/array_data_model.js"></script>

	20 <script src="chrome://resources/js/cr/ui/list_selection_controller.js"></script>

	21 <script src="chrome://resources/js/cr/ui/list_selection_model.js"></script>

	22 <script src="chrome://resources/js/cr/ui/list_single_selection_model.js"></scrip t>

	23 <script src="chrome://resources/js/cr/ui/list.js"></script>

	24 <script src="chrome://resources/js/cr/ui/list_item.js"></script>

	25 <script src="chrome://resources/js/cr/ui/grid.js"></script>

	26 <script src="chrome://resources/js/cr/ui/menu_item.js"></script>

	27 <script src="chrome://resources/js/cr/ui/menu.js"></script>

	28 <script src="chrome://resources/js/cr/ui/menu_button.js"></script>

	29 <script src="chrome://resources/js/load_time_data.js"></script>

	30 <script src="chrome://resources/js/util.js"></script>

	31 <script src="user_chooser.js"></script>

	32 <script src="chrome://user-chooser/strings.js"></script>

	33 </head>

	34 <body class="login-display" i18n-values=".style.fontFamily:fontfamily;">

	35 <div id="outer-container">

	36 <div id="oobe" class="faded">

	37 <div id="inner-container" class="down">
	Nikita (slow) 2013/06/14 16:51:35 nit: 2 space indentation nit: 2 space indentation Nikita (slow) 2013/06/14 16:51:35 nit: drop class="down" attribute, only needed on C nit: drop class="down" attribute, only needed on CrOS boot. noms (inactive) 2013/06/28 17:31:04 Done. Show quoted text On 2013/06/14 16:51:35, Nikita Kostylev wrote: > nit: drop class="down" attribute, only needed on CrOS boot. Done. noms (inactive) 2013/06/28 17:31:04 Done. Show quoted text On 2013/06/14 16:51:35, Nikita Kostylev wrote: > nit: 2 space indentation Done.
	38 <div id="step-logo" hidden>

	39 <div id="header-sections"></div>

	40 </div>
	Nikita (slow) 2013/06/14 16:51:35 nit: align with opening div tag nit: align with opening div tag noms (inactive) 2013/06/28 17:31:04 Done. Show quoted text On 2013/06/14 16:51:35, Nikita Kostylev wrote: > nit: align with opening div tag Done.
	41 <include src="../chromeos/login/screen_account_picker.html">

	42 </div>
	Nikita (slow) 2013/06/14 16:51:35 nit: align with opening div tag nit: align with opening div tag noms (inactive) 2013/06/28 17:31:04 Done. Show quoted text On 2013/06/14 16:51:35, Nikita Kostylev wrote: > nit: align with opening div tag Done.
	43 </div>

	44 </div>

	45 <div id="bubble" class="bubble faded" hidden></div>
	Nikita (slow) 2013/06/14 16:51:35 nit: 2 space indentation nit: 2 space indentation noms (inactive) 2013/06/28 17:31:04 Hmm, does this need to be indented, given that it' Hmm, does this need to be indented, given that it's just under the body, at the same level as login-display? On 2013/06/14 16:51:35, Nikita Kostylev wrote: Show quoted text > nit: 2 space indentation Nikita (slow) 2013/07/02 14:20:12 Yes, it should. In fact everything inside <body> ( Show quoted text On 2013/06/28 17:31:04, Monica Dinculescu wrote: > Hmm, does this need to be indented, given that it's just under the body, at the > same level as login-display? > On 2013/06/14 16:51:35, Nikita Kostylev wrote: > > nit: 2 space indentation > Yes, it should. In fact everything inside <body> (like <div id="outer-container">) should also be indented.
	46 <include src="control_bar.html">

	47 <include src="desktop_user_pod_template.html">

	48 <script src="chrome://resources/js/i18n_template2.js"></script>

	49 </body>

	50 </html>

OLD	NEW