First try at a user management screen for the desktop

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 148 matching lines @@
 
 void QueueProfileDirectoryForDeletion(const base::FilePath& path) {
   ProfilesToDelete().push_back(path);
 }
 
 bool IsProfileMarkedForDeletion(const base::FilePath& profile_path) {
   return std::find(ProfilesToDelete().begin(), ProfilesToDelete().end(),
       profile_path) != ProfilesToDelete().end();
 }
 
+void OpenBrowserWindowForProfile(bool always_create,
+                                 chrome::HostDesktopType desktop_type,
+                                 Profile* profile,
+                                 Profile::CreateStatus status) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  if (status == Profile::CREATE_STATUS_INITIALIZED) {
+    ProfileManager::FindOrCreateNewWindowForProfile(
+        profile,
+        chrome::startup::IS_NOT_PROCESS_STARTUP,
+        chrome::startup::IS_NOT_FIRST_RUN,
+        desktop_type,
+        always_create);
+  }
+}
+
 #if defined(OS_CHROMEOS)
 void CheckCryptohomeIsMounted(chromeos::DBusMethodCallStatus call_status,
                               bool is_mounted) {
   if (call_status != chromeos::DBUS_METHOD_CALL_SUCCESS) {
     LOG(ERROR) << "IsMounted call failed.";
     return;
   }
   if (!is_mounted)
     LOG(ERROR) << "Cryptohome is not mounted.";
 }
@@ skipping 442 matching lines @@
 
   content::RecordAction(UserMetricsAction("NewWindow"));
   CommandLine command_line(CommandLine::NO_PROGRAM);
   int return_code;
   StartupBrowserCreator browser_creator;
   browser_creator.LaunchBrowser(command_line, profile, base::FilePath(),
                                 process_startup, is_first_run, &return_code);
 #endif  // defined(OS_IOS)
 }
 
+// static
+void ProfileManager::SwitchToProfile(

[sail, 2013/07/02 21:46:40]

I don't think there's any value in having this in ProfileManager. Can we keep
all this in AvatarMenuModel instead?

[noms, 2013/07/03 17:11:35]

The reason I moved it here is that the user chooser page also needs to open a
window for a selected profile, and as it is, it would need to instantiate a
mostly-unused AvatarMenuModel. Roger had suggested in a previous comment to
factor it out to a standalone function. Given that it calls CreateProfileAsync
on the profile manager (and doesn't really do anything about the avatars), I
thought the ProfileManager would be a better place for it. Do you think it
should be a static function in the AvatarMenuModel instead? 

On 2013/07/02 21:46:40, sail wrote:

[sail, 2013/07/03 18:18:04]

Adding this to profile manager is a bad idea.
The profile manager API is already more complicated than it needs to be.

[noms, 2013/07/05 17:39:27]

As discussed offline, this is ok because it's only adding one static function,
that needs to be called from placed that aren't just the AvatarMenuModel, and
whose functionality is only related to the ProfileManager.

On 2013/07/03 18:18:04, sail wrote:

+    const base::FilePath& path,
+    chrome::HostDesktopType desktop_type,
+    bool always_create) {
+  g_browser_process->profile_manager()->CreateProfileAsync(
+      path,
+      base::Bind(&OpenBrowserWindowForProfile,
+                 always_create,
+                 desktop_type),
+      string16(),
+      string16(),
+      false);
+}
+
 void ProfileManager::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
 #if defined(OS_CHROMEOS)
   if (type == chrome::NOTIFICATION_LOGIN_USER_CHANGED) {
     logged_in_ = true;
 
     const CommandLine& command_line = *CommandLine::ForCurrentProcess();
     if (!command_line.HasSwitch(switches::kTestType)) {
@@ skipping 572 matching lines @@
 ProfileManager::ProfileInfo::ProfileInfo(
     Profile* profile,
     bool created)
     : profile(profile),
       created(created) {
 }
 
 ProfileManager::ProfileInfo::~ProfileInfo() {
   ProfileDestroyer::DestroyProfileWhenAppropriate(profile.release());
 }