Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1610303002: Use std::set to track visited dictionaries in fsdk_actionhandler. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use std::set to track visited dictionaries in fsdk_actionhandler. Find() in a list isn't the best idea. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f409da4b8a3e6a3885605a47bed4f8798c4703b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -50 lines) Patch
M fpdfsdk/include/fsdk_actionhandler.h View 2 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 13 chunks +48 lines, -43 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Tom Sepez
ochang, small optimization.
4 years, 11 months ago (2016-01-20 21:56:49 UTC) #3
Oliver Chang
lgtm
4 years, 11 months ago (2016-01-20 22:06:19 UTC) #4
Tom Sepez
4 years, 11 months ago (2016-01-20 22:42:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f409da4b8a3e6a3885605a47bed4f8798c4703b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698