media/audio/virtual_audio_output_stream.cc - Issue 16103007: Privitize WaitTillDataReady() and DataReady().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/virtual_audio_output_stream.cc

Issue 16103007: Privitize WaitTillDataReady() and DataReady(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/virtual_audio_output_stream.cc

diff --git a/media/audio/virtual_audio_output_stream.cc b/media/audio/virtual_audio_output_stream.cc

index 005fbc2ad644bace89470fda50a8e6d70111b29c..254a70a517a4d3a9e398bf3c03059b61a7674798 100644

--- a/media/audio/virtual_audio_output_stream.cc

+++ b/media/audio/virtual_audio_output_stream.cc

@@ -74,10 +74,6 @@ double VirtualAudioOutputStream::ProvideInput(AudioBus* audio_bus,

DCHECK(message_loop_->BelongsToCurrentThread());

DCHECK(callback_);

- // A VirtualAudioInputStream with a larger buffer size may be calling this

- // multiple times without waiting, so we need to block and ensure the data is

- // ready to prevent glitching.

- callback_->WaitTillDataReady();

const int frames = callback_->OnMoreData(audio_bus, AudioBuffersState());

if (frames < audio_bus->frames())

audio_bus->ZeroFramesPartial(frames, audio_bus->frames() - frames);