media/audio/pulse/pulse_input.cc - Issue 16103007: Privitize WaitTillDataReady() and DataReady().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/pulse/pulse_input.cc

Issue 16103007: Privitize WaitTillDataReady() and DataReady(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Gotta catch'em all! Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/pulse/pulse_input.cc

diff --git a/media/audio/pulse/pulse_input.cc b/media/audio/pulse/pulse_input.cc

index c365c47b1bc6dbcb94bda31a9ee539eb07c85dca..cc6208527db06c316d41a04d9f63ff0b7d5edf61 100644

--- a/media/audio/pulse/pulse_input.cc

+++ b/media/audio/pulse/pulse_input.cc

@@ -278,8 +278,7 @@ void PulseAudioInputStream::ReadData() {

if (buffer_->forward_bytes() < packet_size)

break;

- // TODO(xians): improve the code by implementing a WaitTillDataReady on the

- // input side.

+ // TODO(xians): Remove once PPAPI is using circular buffers.

DVLOG(1) << "OnData is being called consecutively, sleep 5ms to "

<< "wait until render consumes the data";

base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(5));

« no previous file with comments | « media/audio/linux/alsa_output.cc ('k') | media/audio/pulse/pulse_output.cc » ('j') | no next file with comments »