Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 16103006: Add stub icons for playpen. (Closed)

Created:
7 years, 7 months ago by Denis Kuznetsov (DE-MUC)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add stub icons for playpen. +remove separators in creation dialogs. TBR=derat@chromium.org, nkostylev@chromium.org, oshima@chromium.org NOTRY=true Because of changes in binaries. BUG=229762 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202936

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge with ToT #

Patch Set 3 : Merge with ToT #

Messages

Total messages: 10 (0 generated)
Denis Kuznetsov (DE-MUC)
Oshima for grd/png files in ash/resources and chrome/app/theme. Daniel as owner of ash/system/chromeos/managed/tray_locally_managed_user.cc Nikita for ...
7 years, 7 months ago (2013-05-27 15:04:51 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/16103006/diff/1/chrome/browser/resources/chromeos/login/user_pod_row.css File chrome/browser/resources/chromeos/login/user_pod_row.css (right): https://codereview.chromium.org/16103006/diff/1/chrome/browser/resources/chromeos/login/user_pod_row.css#newcode227 chrome/browser/resources/chromeos/login/user_pod_row.css:227: height: 16px; It is the same 16x16 icon, ...
7 years, 7 months ago (2013-05-27 15:46:46 UTC) #2
Denis Kuznetsov (DE-MUC)
https://codereview.chromium.org/16103006/diff/1/chrome/browser/resources/chromeos/login/user_pod_row.css File chrome/browser/resources/chromeos/login/user_pod_row.css (right): https://codereview.chromium.org/16103006/diff/1/chrome/browser/resources/chromeos/login/user_pod_row.css#newcode227 chrome/browser/resources/chromeos/login/user_pod_row.css:227: height: 16px; On 2013/05/27 15:46:46, Nikita Kostylev wrote: > ...
7 years, 7 months ago (2013-05-27 15:49:19 UTC) #3
Daniel Erat
lgtm
7 years, 7 months ago (2013-05-27 17:15:49 UTC) #4
oshima
don't you need 200% images as well?
7 years, 6 months ago (2013-05-28 17:01:01 UTC) #5
Denis Kuznetsov (DE-MUC)
On 2013/05/28 17:01:01, oshima wrote: > don't you need 200% images as well? That is ...
7 years, 6 months ago (2013-05-28 17:07:03 UTC) #6
oshima
On 2013/05/28 17:07:03, Denis Kuznetsov wrote: > On 2013/05/28 17:01:01, oshima wrote: > > don't ...
7 years, 6 months ago (2013-05-28 18:04:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/16103006/1
7 years, 6 months ago (2013-05-28 19:11:53 UTC) #8
commit-bot: I haz the power
Can't process patch for file ash/resources/default_100_percent/cros/status/status_managed_mode_user.png. Binary file support is temporarilly disabled due to a ...
7 years, 6 months ago (2013-05-28 19:11:54 UTC) #9
Denis Kuznetsov (DE-MUC)
7 years, 6 months ago (2013-05-29 19:33:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r202936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698