scripts/slave/recipe_modules/bisect_tester/api.py - Issue 1610203003: Iteratively increase sample size for good/bad classification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/bisect_tester/api.py

Issue 1610203003: Iteratively increase sample size for good/bad classification. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Rebasing Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/revision_state.py ('k') | scripts/slave/recipe_modules/bisect_tester/perf_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/bisect_tester/api.py

diff --git a/scripts/slave/recipe_modules/bisect_tester/api.py b/scripts/slave/recipe_modules/bisect_tester/api.py

index 4ab8c311fced57aa59bc5a7dc7568c97eddd0ab9..53181308999431813973d751cb20ebcf3688d76a 100644

--- a/scripts/slave/recipe_modules/bisect_tester/api.py

+++ b/scripts/slave/recipe_modules/bisect_tester/api.py

@@ -31,7 +31,8 @@ class BisectTesterApi(recipe_api.RecipeApi):

'command': bisect_config['command'],

'metric': bisect_config.get('metric'),

'repeat_count': int(bisect_config.get('repeat_count', 20)),

- 'max_time_minutes': float(bisect_config.get('max_time_minutes', 25)),

+ # The default is to NOT timeout, hence 0.

+ 'max_time_minutes': float(bisect_config.get('max_time_minutes', 0)),

'test_type': bisect_config.get('test_type', 'perf')

}