Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 1610193002: Convert CanvasStateTest to the new saveLayer API (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 11 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert CanvasStateTest to the new saveLayer API The test needs to still work when SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG is defined but SK_SUPPORT_LEGACY_SAVEFLAGS is not. R=reed@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1610193002 Committed: https://skia.googlesource.com/skia/+/55b29b255187a65c056029f26442b9e9c9d6b2cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M tests/CanvasStateTest.cpp View 7 chunks +22 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
f(malita)
We'll hopefully remove SK_SUPPORT_LEGACY_SAVEFLAGS soonish, but SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG is going to stick around for now.
4 years, 11 months ago (2016-01-20 18:32:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610193002/1
4 years, 11 months ago (2016-01-20 18:32:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 18:46:40 UTC) #6
reed1
lgtm
4 years, 11 months ago (2016-01-20 19:10:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610193002/1
4 years, 11 months ago (2016-01-20 19:17:16 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 19:17:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/55b29b255187a65c056029f26442b9e9c9d6b2cd

Powered by Google App Engine
This is Rietveld 408576698