Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2317)

Unified Diff: chrome/browser/chromeos/policy/system_log_uploader_unittest.cc

Issue 1610123003: Added anonymizer to SystemLogUploader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/system_log_uploader_unittest.cc
diff --git a/chrome/browser/chromeos/policy/system_log_uploader_unittest.cc b/chrome/browser/chromeos/policy/system_log_uploader_unittest.cc
index e30311cb60c1bae8e3bf17caab2bd36b3cf7d610..e978fab03602a76c72b7da7b46cf4de02d65376a 100644
--- a/chrome/browser/chromeos/policy/system_log_uploader_unittest.cc
+++ b/chrome/browser/chromeos/policy/system_log_uploader_unittest.cc
@@ -286,25 +286,35 @@ TEST_F(SystemLogUploaderTest, DisableLogUpload) {
SystemLogUploader::kDefaultUploadDelayMs));
}
-// Test RemovePII function.
+// Test RemovePII function: ensure that AnonymizerTool handles IPv4, IPv6,
+// SSID, BSSID/MAC address, Email address, URL.
TEST_F(SystemLogUploaderTest, TestPII) {
+ SystemLogUploader uploader(nullptr, task_runner_);
std::string data =
- "aaaaaaaaSSID=123aaaaaaaaaaa\n" // SSID.
+ "aaaaaaaa SSID='123aaaaaaaaaaa'\n" // SSID.
"aaaaaaaahttp://tets.comaaaaaaa\n" // URL.
"aaaaaemail@example.comaaa\n" // Email address.
- "example@@1234\n" // No PII, it is not valid email address.
- "255.255.355.255\n" // No PII, it is not valid IP address format.
- "aaaa123.123.45.4aaa\n" // IP address.
- "11:11;11::11\n" // IP address.
- "11::11\n" // IP address.
- "11:11:abcdef:0:0:0:0:0"; // No PII, it is not valid IP address format.
+ "example@@1234\n" // No PII, it is not valid email address.
+ "255.255.355.255\n" // No PII, it is not valid IP address format.
+ "aaaa123.123.45.4aaa\n" // IP address.
+ "11:11;11::11\n" // IP address.
+ "11::11\n" // IP address.
+ "11:11:abcdef:0:0:1:2:3\n" // No PII, it is not valid IP address format.
+ "00:80:c8:e3:4c:BD"; // MAC address.
std::string result =
+ "aaaaaaaa SSID='1'\n"
+ "aaaaaaaa<URL: 1>\n"
+ "<email: 1>\n"
"example@@1234\n"
"255.255.355.255\n"
- "11:11:abcdef:0:0:0:0:0\n";
+ "aaaa<IPv4: 1>aaa\n"
+ "11:11;<IPv6: 1>\n"
+ "<IPv6: 1>\n"
+ "11:11:abcdef:0:0:1:2:3\n"
+ "00:80:c8:00:00:01";
- EXPECT_EQ(result, SystemLogUploader::RemoveSensitiveData(data));
+ EXPECT_EQ(result, uploader.RemoveSensitiveData(data));
}
} // namespace policy

Powered by Google App Engine
This is Rietveld 408576698