chrome/browser/chromeos/policy/system_log_uploader_unittest.cc - Issue 1610123003: Added anonymizer to SystemLogUploader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/system_log_uploader_unittest.cc

Issue 1610123003: Added anonymizer to SystemLogUploader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/system_log_uploader.cc ('K') | « chrome/browser/chromeos/policy/system_log_uploader.cc ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/system_log_uploader_unittest.cc

diff --git a/chrome/browser/chromeos/policy/system_log_uploader_unittest.cc b/chrome/browser/chromeos/policy/system_log_uploader_unittest.cc

index e30311cb60c1bae8e3bf17caab2bd36b3cf7d610..d5bbe14dbc6f4f789805978eda9982ab2d722616 100644

--- a/chrome/browser/chromeos/policy/system_log_uploader_unittest.cc

+++ b/chrome/browser/chromeos/policy/system_log_uploader_unittest.cc

@@ -10,6 +10,7 @@

#include "base/test/test_simple_task_runner.h"

#include "base/time/time.h"

#include "chrome/browser/chromeos/settings/scoped_cros_settings_test_helper.h"

+#include "components/feedback/anonymizer_tool.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "content/public/test/test_utils.h"

#include "net/http/http_request_headers.h"

@@ -288,23 +289,31 @@ TEST_F(SystemLogUploaderTest, DisableLogUpload) {

// Test RemovePII function.

TEST_F(SystemLogUploaderTest, TestPII) {

+ feedback::AnonymizerTool anonymizer;

std::string data =

- "aaaaaaaaSSID=123aaaaaaaaaaa\n" // SSID.

+ "aaaaaaaa [SSID=123aaaaaa]aaaaa\n" // SSID.

"aaaaaaaahttp://tets.comaaaaaaa\n" // URL.

"aaaaaemail@example.comaaa\n" // Email address.

- "example@@1234\n" // No PII, it is not valid email address.

- "255.255.355.255\n" // No PII, it is not valid IP address format.

- "aaaa123.123.45.4aaa\n" // IP address.

- "11:11;11::11\n" // IP address.

- "11::11\n" // IP address.

- "11:11:abcdef:0:0:0:0:0"; // No PII, it is not valid IP address format.

+ "example@@1234\n" // No PII, it is not valid email address.

+ "255.255.155.255\n" // IP address.

+ "aaaa123.123.45.4aaa\n" // IP address.

+ "11:11;11::11\n" // IP address.

+ "11::11\n" // IP address.

+ "11:11:abcdef:0:0:0:0:0\n" // No PII.

+ "aa:aa:aa:aa:aa:aa"; // MAC address (BSSID).

std::string result =

+ "aaaaaaaa [SSID=1]aaaaa\n"

+ "aaaaaaaa<URL: 1>\n"

+ "<email: 1>\n"

"example@@1234\n"

- "255.255.355.255\n"

- "11:11:abcdef:0:0:0:0:0\n";

- EXPECT_EQ(result, SystemLogUploader::RemoveSensitiveData(data));

+ "<IPv4: 1>55\n"

+ "aaaa<IPv4: 2>aaa\n"

+ "11:11;<IPv6: 1>\n"

+ "<IPv6: 1>\n"

+ "11:11:abcdef:0:0:0:0:0\n"

+ "aa:aa:aa:00:00:01";

+ EXPECT_EQ(result, SystemLogUploader::RemoveSensitiveData(&anonymizer, data));

}

} // namespace policy