Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4137)

Unified Diff: chrome/browser/chromeos/policy/system_log_uploader.h

Issue 1610123003: Added anonymizer to SystemLogUploader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/system_log_uploader.h
diff --git a/chrome/browser/chromeos/policy/system_log_uploader.h b/chrome/browser/chromeos/policy/system_log_uploader.h
index 5a3d6243c12737285c12f1ce5d68f0f322f0ea77..48683a0fcf6b03911a46ceddc4953799efac9fd3 100644
--- a/chrome/browser/chromeos/policy/system_log_uploader.h
+++ b/chrome/browser/chromeos/policy/system_log_uploader.h
@@ -21,6 +21,10 @@ namespace base {
class SequencedTaskRunner;
}
+namespace feedback {
+class AnonymizerTool;
+}
+
namespace policy {
// Class responsible for periodically uploading system logs, it handles the
@@ -78,9 +82,10 @@ class SystemLogUploader : public UploadJob::Delegate {
void OnSuccess() override;
void OnFailure(UploadJob::ErrorCode error_code) override;
- // Remove lines from |data| that contain common PII (IP addresses, SSIDs, URLs
- // e-mail addresses).
- static std::string RemoveSensitiveData(const std::string& data);
+ // Remove lines from |data| that contain common PII (IP addresses, BSSIDs,
+ // SSIDs, URLs, e-mail addresses).
+ static std::string RemoveSensitiveData(feedback::AnonymizerTool& anonymizer,
Andrew T Wilson (Slow) 2016/01/25 11:06:42 If you're passing in an anonymizer by reference, t
Polina Bondarenko 2016/01/25 15:08:33 Fixed to const ptr. The object can't be const, be
+ const std::string& data);
private:
// Updates the system log upload enabled field from settings.

Powered by Google App Engine
This is Rietveld 408576698